From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28910 invoked by alias); 7 Nov 2010 22:26:39 -0000 Received: (qmail 28883 invoked by uid 22791); 7 Nov 2010 22:26:37 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_CP,TW_EG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 07 Nov 2010 22:26:31 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oA7MQTqG012039 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 7 Nov 2010 17:26:30 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id oA7MQOKO018425 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 7 Nov 2010 17:26:29 -0500 Received: from host0.dyn.jankratochvil.net (localhost.localdomain [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id oA7MQLkX001853 for ; Sun, 7 Nov 2010 23:26:22 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id oA7MQJZ9001852 for gdb-patches@sourceware.org; Sun, 7 Nov 2010 23:26:19 +0100 Date: Sun, 07 Nov 2010 22:26:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: [obv] Fix infcall small memory leak Message-ID: <20101107222619.GA8516@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00110.txt.bz2 Hi, discard_inferior_thread_state was not updated by me before for the new field siginfo_data. No regressions on {x86_64,x86_64-m32,i686}-fedora14snapshot-linux-gnu. Checked-in. Thanks, Jan http://sourceware.org/ml/gdb-cvs/2010-11/msg00037.html --- src/gdb/ChangeLog 2010/11/05 16:55:33 1.12300 +++ src/gdb/ChangeLog 2010/11/07 22:25:15 1.12301 @@ -1,3 +1,9 @@ +2010-11-07 Jan Kratochvil + + * infrun.c (restore_inferior_thread_state): Use + discard_inferior_thread_state to free the data. + (discard_inferior_thread_state): xfree also siginfo_data. + 2010-11-05 Doug Evans Make gdb.parameter("directories") work. --- src/gdb/infrun.c 2010/11/02 01:37:31 1.454 +++ src/gdb/infrun.c 2010/11/07 22:25:16 1.455 @@ -6128,9 +6128,8 @@ if (target_has_execution) /* NB: The register write goes through to the target. */ regcache_cpy (regcache, inf_state->registers); - regcache_xfree (inf_state->registers); - xfree (inf_state->siginfo_data); - xfree (inf_state); + + discard_inferior_thread_state (inf_state); } static void @@ -6149,6 +6148,7 @@ discard_inferior_thread_state (struct inferior_thread_state *inf_state) { regcache_xfree (inf_state->registers); + xfree (inf_state->siginfo_data); xfree (inf_state); }