Re: [doc RFA] Switch to GCC coding style [Re: [patch] initial OpenCL C language support]

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Tue, 02 Nov 2010 20:20:32 +0100, Eli Zaretskii wrote:
> Are you submitting this for doc review, or will we discuss the issue
> first?

I thought about it as a quick fix as currently the code follows different
rules ("!" - GCC) than what states gdbint.texinfo ("! " - GNU).  At least
Pedro says "We tend to follow these already".


> I don't think this is enough, sorry.  The GCC Conventions mention a
> lot of details that are utterly inapplicable to GDB.  The exceptions
> you mention are just a drop in that sea.  What about references to
> ERROR_MARK, RTL, --param arguments, what about fastjar and boehm-gc?
> And those are just a few random examples.
> 
> On balance, I think we should simply have our own coherent document.

Yes, it would be better.  But I am not going to spend the time on it myself.


> Any other way, we will just confuse potential contributors:

They are already confused now (at least I have been confused by "!" vs. "! "
so far myself) and IMO the proposed patch reduces the confusion.


> To say nothing of the fact that they will now have to read two documents
> instead of 1.

3 instead of 2 (besides GNU Coding Standards and gdbint.texinfo Coding
Standards proposing also GCC Coding Conventions).


Regards,
Jan