From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23270 invoked by alias); 12 Nov 2010 12:58:18 -0000 Received: (qmail 23260 invoked by uid 22791); 12 Nov 2010 12:58:17 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate5.uk.ibm.com (HELO mtagate5.uk.ibm.com) (194.196.100.165) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 12 Nov 2010 12:57:44 +0000 Received: from d06nrmr1307.portsmouth.uk.ibm.com (d06nrmr1307.portsmouth.uk.ibm.com [9.149.38.129]) by mtagate5.uk.ibm.com (8.13.1/8.13.1) with ESMTP id oACCvfFl014707 for ; Fri, 12 Nov 2010 12:57:41 GMT Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by d06nrmr1307.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id oACCve6H3555532 for ; Fri, 12 Nov 2010 12:57:40 GMT Received: from d06av07.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oACCveon027032 for ; Fri, 12 Nov 2010 05:57:41 -0700 Received: from leonard.localnet (dyn-9-152-224-23.boeblingen.de.ibm.com [9.152.224.23]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id oACCvbvk026955 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 12 Nov 2010 05:57:39 -0700 From: Ken Werner To: Pedro Alves Subject: Re: [patch] Add visible flag to breakpoints. Date: Fri, 12 Nov 2010 12:58:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-22-generic-pae; KDE/4.5.1; i686; ; ) Cc: pmuldoon@redhat.com, gdb-patches@sourceware.org, Tom Tromey , dan@codesourcery.com, eliz@gnu.org, Jan Kratochvil References: <201011121343.27553.ken@linux.vnet.ibm.com> <201011121249.26308.pedro@codesourcery.com> In-Reply-To: <201011121249.26308.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201011121357.36687.ken@linux.vnet.ibm.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00155.txt.bz2 On Friday, November 12, 2010 1:49:25 pm Pedro Alves wrote: > On Friday 12 November 2010 12:43:27, Ken Werner wrote: > > On Thursday, November 11, 2010 3:36:21 pm Phil Muldoon wrote: > > > So committed, thanks > > > > This change introduces a small typo in the spu-tdep.c file which prevents > > the gdb from compiling if --target=spu is enabled. The attached patch > > fixes this issue. Ok to apply? > > Sure, thanks. FYI, obvious patches don't really require approval. I was just about committing the change and saw that Jan Kratochvil already fixed this a minute ago: http://sourceware.org/ml/gdb- cvs/2010-11/msg00055.html Thanks Ken