From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76403-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6430 invoked by alias); 12 Nov 2010 18:43:52 -0000
Received: (qmail 6420 invoked by uid 22791); 12 Nov 2010 18:43:51 -0000
X-SWARE-Spam-Status: No, hits=-6.2 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 12 Nov 2010 18:43:45 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oACIhhjx001717	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Fri, 12 Nov 2010 13:43:43 -0500
Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oACIhdrO021370	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);	Fri, 12 Nov 2010 13:43:42 -0500
Received: from host0.dyn.jankratochvil.net (localhost.localdomain [127.0.0.1])	by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id oACIha83017869;	Fri, 12 Nov 2010 19:43:37 +0100
Received: (from jkratoch@localhost)	by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id oACIhYSE017868;	Fri, 12 Nov 2010 19:43:34 +0100
Date: Fri, 12 Nov 2010 18:43:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 1/2] Code cleanup: New init_one_comp_unit
Message-ID: <20101112184333.GA17824@host0.dyn.jankratochvil.net>
References: <20101107035032.GA8598@host0.dyn.jankratochvil.net> <m31v6q5qs8.fsf@fleche.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m31v6q5qs8.fsf@fleche.redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-11/txt/msg00160.txt.bz2

On Fri, 12 Nov 2010 19:40:39 +0100, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> 
> Jan> unify some code into a function, to be extended in the next patch.
> 
> Looks good to me.

I have prepared a second patch now to address Joel's suggestion to rather look
up symbols case insensitively instead of lowercasing them on read-in.

But maybe this patch is OK anyway although the cleanup could be more complete.

(Not yet checked in.)


Thanks,
Jan