public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: dje@google.com (Doug Evans)
To: gdb-patches@sourceware.org
Subject: [commit] increase timeout for "maint print statistics" test
Date: Mon, 15 Nov 2010 17:20:00 -0000	[thread overview]
Message-ID: <20101115172018.6E05C2461AA@ruffy.mtv.corp.google.com> (raw)

Hi.

fyi, I checked this in.
I happened to see a timeout on a linux machine I was testing on
so I just increased the timeout for all targets.
Plus the test wasn't restoring the timeout afterwards.

2010-11-15  Doug Evans  <dje@google.com>

	* gdb.base/maint.exp (maint print statistics): Increase timeout for
	all targets.  Restore old timeout afterwards.

Index: gdb.base/maint.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/maint.exp,v
retrieving revision 1.49
diff -u -p -r1.49 maint.exp
--- gdb.base/maint.exp	9 Nov 2010 04:44:17 -0000	1.49
+++ gdb.base/maint.exp	15 Nov 2010 17:14:06 -0000
@@ -143,11 +143,10 @@ gdb_test "maint demangle main" "Can't de
 
 # The timeout value is raised, because printing all the symbols and
 # statistical information about Cygwin and Windows libraries takes a lot
-# of time.
-if [istarget "*-*-cygwin*"] {
-	set oldtimeout $timeout
-	set timeout [expr $timeout + 500]
-}
+# of time.  This has been noticed on some linux systems too, so just raise
+# the timeout globally.
+set oldtimeout $timeout
+set timeout [expr $timeout + 500]
 
 send_gdb "maint print statistics\n"
 gdb_expect  {
@@ -163,6 +162,8 @@ gdb_expect  {
     timeout         { fail "(timeout) maint print statistics" }
 }
 
+set timeout $oldtimeout
+
 # There aren't any ...
 gdb_test_no_output "maint print dummy-frames"
 

             reply	other threads:[~2010-11-15 17:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-15 17:20 Doug Evans [this message]
2010-11-15 17:26 ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101115172018.6E05C2461AA@ruffy.mtv.corp.google.com \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).