From: Joel Brobecker <brobecker@adacore.com>
To: Masaki Muranaka <monaka@monami-software.com>, eager@eagercon.com
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] target triplet for Microblaze.
Date: Thu, 18 Nov 2010 17:10:00 -0000 [thread overview]
Message-ID: <20101118171030.GA2634@adacore.com> (raw)
In-Reply-To: <C43B1DF2-094E-4DFE-9BD4-7C0EA06EABC8@monami-software.com>
> The CVS head can't accept microblaze*-(manufacturer)-elf and
> microblaze*-(manufacturer)-linux* as the target triplet. This
> behavior is not based upon the description in Autobook.
> http://sourceware.org/autobook/autobook/autobook_17.html
I don't mind allowing another manufacturer than xilinx in the target
triplet for the microblaze, but I'm just curious. Are there any others?
If that's the case, perhaps we want to adjust the comments saying
"Xilinx Microblaze" and remove "Xilinx"...
Also, `microblaze*-linux-*' is there to allow "microblaze-linux-gnu".
I'm not sure this is really kosher or not. I would think not (we're in
danger of thinking that the OS name is "gnu" rather than "linux". But
keeping it if needed shouldn't be too much of a burden as long as this
is limited to configure.tgt.
> 2010-11-18 Masaki Muranaka <monaka@monami-software.com>
>
> * configure.tgt: Accept microblaze*-*-linux* for linux target
> and microblaze*-*-* for as target.
Other than that, this seems fine to me. Cc'ing Michael Eager
in case he has any additional comment.
> - - - - -
> diff --git a/gdb/configure.tgt b/gdb/configure.tgt
> index bca2260..e065e70 100644
> --- a/gdb/configure.tgt
> +++ b/gdb/configure.tgt
> @@ -323,14 +323,14 @@ mep-*-*)
> # No sim needed. Target uses SID.
> ;;
>
> -microblaze*-linux-*)
> +microblaze*-linux-*|microblaze*-*-linux*)
> # Target: Xilinx MicroBlaze running Linux
> gdb_target_obs="microblaze-tdep.o microblaze-linux-tdep.o microblaze-rom.o
> monitor.o dsrec.o solib.o solib-svr4.o corelow.o \
> symfile-mem.o linux-tdep.o"
> gdb_sim=../sim/microblaze/libsim.a
> ;;
> -microblaze*-xilinx-*)
> +microblaze*-*-*)
> # Target: Xilinx MicroBlaze running standalone
> gdb_target_obs="microblaze-tdep.o microblaze-rom.o monitor.o dsrec.o"
> gdb_sim=../sim/microblaze/libsim.a
--
Joel
next prev parent reply other threads:[~2010-11-18 17:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 9:23 Masaki Muranaka
2010-11-18 17:10 ` Joel Brobecker [this message]
2010-11-18 17:44 ` Michael Eager
2010-11-18 18:14 ` Pedro Alves
2010-11-18 18:44 ` Michael Eager
2010-11-18 20:45 ` Pedro Alves
2010-11-18 21:35 ` Michael Eager
2010-11-18 21:49 ` Pedro Alves
2010-11-18 22:32 ` Joel Brobecker
2010-11-18 22:53 ` Michael Eager
2010-12-04 2:12 ` Masaki Muranaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118171030.GA2634@adacore.com \
--to=brobecker@adacore.com \
--cc=eager@eagercon.com \
--cc=gdb-patches@sourceware.org \
--cc=monaka@monami-software.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).