From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26303 invoked by alias); 18 Nov 2010 17:10:43 -0000 Received: (qmail 26291 invoked by uid 22791); 18 Nov 2010 17:10:41 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,TW_YM X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Nov 2010 17:10:35 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6609F2BAB68; Thu, 18 Nov 2010 12:10:33 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Jawa9WlU7V5L; Thu, 18 Nov 2010 12:10:33 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id F17162BABF3; Thu, 18 Nov 2010 12:10:32 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id F3370145B6C; Thu, 18 Nov 2010 09:10:30 -0800 (PST) Date: Thu, 18 Nov 2010 17:10:00 -0000 From: Joel Brobecker To: Masaki Muranaka , eager@eagercon.com Cc: gdb-patches@sourceware.org Subject: Re: [patch] target triplet for Microblaze. Message-ID: <20101118171030.GA2634@adacore.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00235.txt.bz2 > The CVS head can't accept microblaze*-(manufacturer)-elf and > microblaze*-(manufacturer)-linux* as the target triplet. This > behavior is not based upon the description in Autobook. > http://sourceware.org/autobook/autobook/autobook_17.html I don't mind allowing another manufacturer than xilinx in the target triplet for the microblaze, but I'm just curious. Are there any others? If that's the case, perhaps we want to adjust the comments saying "Xilinx Microblaze" and remove "Xilinx"... Also, `microblaze*-linux-*' is there to allow "microblaze-linux-gnu". I'm not sure this is really kosher or not. I would think not (we're in danger of thinking that the OS name is "gnu" rather than "linux". But keeping it if needed shouldn't be too much of a burden as long as this is limited to configure.tgt. > 2010-11-18 Masaki Muranaka > > * configure.tgt: Accept microblaze*-*-linux* for linux target > and microblaze*-*-* for as target. Other than that, this seems fine to me. Cc'ing Michael Eager in case he has any additional comment. > - - - - - > diff --git a/gdb/configure.tgt b/gdb/configure.tgt > index bca2260..e065e70 100644 > --- a/gdb/configure.tgt > +++ b/gdb/configure.tgt > @@ -323,14 +323,14 @@ mep-*-*) > # No sim needed. Target uses SID. > ;; > > -microblaze*-linux-*) > +microblaze*-linux-*|microblaze*-*-linux*) > # Target: Xilinx MicroBlaze running Linux > gdb_target_obs="microblaze-tdep.o microblaze-linux-tdep.o microblaze-rom.o > monitor.o dsrec.o solib.o solib-svr4.o corelow.o \ > symfile-mem.o linux-tdep.o" > gdb_sim=../sim/microblaze/libsim.a > ;; > -microblaze*-xilinx-*) > +microblaze*-*-*) > # Target: Xilinx MicroBlaze running standalone > gdb_target_obs="microblaze-tdep.o microblaze-rom.o monitor.o dsrec.o" > gdb_sim=../sim/microblaze/libsim.a -- Joel