From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1818 invoked by alias); 20 Nov 2010 05:34:21 -0000 Received: (qmail 1725 invoked by uid 22791); 20 Nov 2010 05:34:20 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 20 Nov 2010 05:34:15 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 428DE2BAB11; Sat, 20 Nov 2010 00:34:14 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id SCk7ZFulYeZ8; Sat, 20 Nov 2010 00:34:14 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id F08E92BAB01; Sat, 20 Nov 2010 00:34:13 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id CF6E71457E0; Fri, 19 Nov 2010 21:34:08 -0800 (PST) Date: Sat, 20 Nov 2010 05:34:00 -0000 From: Joel Brobecker To: Edjunior Barbosa Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] testsuite: asm-source.exp: add powerpc64 support Message-ID: <20101120053408.GQ2634@adacore.com> References: <1289374182-14133-1-git-send-email-emachado@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1289374182-14133-1-git-send-email-emachado@linux.vnet.ibm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00289.txt.bz2 > gdb/testsuite/ > 2010-11-10 Edjunior Machado > > * asm-source.exp: Add new target "powerpc64"; expect leading `.' > on ppc64's symbols; "finish" and "return" commands must accept to > show the caller line again as well as the line after. > * powerpc64.inc: New file > * powerpc.inc: Use 'sys_exit' This looks fine to me. The powerpc.inc change could have been submitted separately, I think... -- Joel