From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2326 invoked by alias); 13 Dec 2010 15:07:40 -0000 Received: (qmail 2309 invoked by uid 22791); 13 Dec 2010 15:07:39 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 13 Dec 2010 15:07:34 +0000 Received: (qmail 26481 invoked from network); 13 Dec 2010 15:07:32 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 13 Dec 2010 15:07:32 -0000 From: Pedro Alves To: pmuldoon@redhat.com Subject: Re: [patch] Add an evaluation function hook to Python breakpoints. Date: Mon, 13 Dec 2010 15:07:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.33-29-realtime; KDE/4.4.5; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <201012131433.44512.pedro@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201012131507.30470.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00185.txt.bz2 On Monday 13 December 2010 14:56:10, Phil Muldoon wrote: > Pedro Alves writes: > > > Can you factor out the PyObject manipulations and the actual evaluation > > of the condition to pythong/py-breakpoint.c? Say, to a > > new "py_breakpoint_evaluate (struct breakpoint_object *, ...)" function. > > The driving idea being to get rid of the need to now include > > python-internal.h. > > Sure I've no problem with that. I think we would still have to include > python.h (but not python-internal.h) inside a HAVE_PYTHON conditional, as > the function would be exposed from py_breakpoint.c via python.h. Right. That's okay. > Is that ok? Or maybe I misread your intentions. You got it. -- Pedro Alves