From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23797 invoked by alias); 19 Jan 2011 18:57:44 -0000 Received: (qmail 23788 invoked by uid 22791); 19 Jan 2011 18:57:43 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate4.uk.ibm.com (HELO mtagate4.uk.ibm.com) (194.196.100.164) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 19 Jan 2011 18:57:37 +0000 Received: from d06nrmr1707.portsmouth.uk.ibm.com (d06nrmr1707.portsmouth.uk.ibm.com [9.149.39.225]) by mtagate4.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p0JIvYFO031809 for ; Wed, 19 Jan 2011 18:57:34 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p0JIvbq01339476 for ; Wed, 19 Jan 2011 18:57:37 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p0JIvYLE029996 for ; Wed, 19 Jan 2011 11:57:34 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id p0JIvXFE029990; Wed, 19 Jan 2011 11:57:33 -0700 Message-Id: <201101191857.p0JIvXFE029990@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 19 Jan 2011 19:57:33 +0100 Subject: Re: PING 3: [patch, testsuite] General ARM target triplet To: rearnsha@arm.com (Richard Earnshaw) Date: Wed, 19 Jan 2011 19:03:00 -0000 From: "Ulrich Weigand" Cc: yao@codesourcery.com (Yao Qi), gdb-patches@sourceware.org In-Reply-To: <1295458009.26870.2.camel@e102346-lin.cambridge.arm.com> from "Richard Earnshaw" at Jan 19, 2011 05:26:49 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00404.txt.bz2 Richard Earnshaw wrote: > On Wed, 2011-01-19 at 09:08 -0700, Yao Qi wrote: > > On 01/13/2011 04:47 AM, Yao Qi wrote: > > > On 01/06/2011 08:10 AM, Yao Qi wrote: > > >> On 12/13/2010 11:39 PM, Pedro Alves wrote: > > >>>>> OK, I combine them together in one single patch this time. > > >>> Thanks. If/when everyone's happy with the triplet bits > > >>> proper, this is okay. > > >> > > >> Ping. Are you happy with this triplet? :-) > > >> > > >> http://sourceware.org/ml/gdb-patches/2010-12/msg00187.html > > >> > > > > > > Ping. > > > > >=20 > > Ping again with a small fix pointed out by Matthew. Richard, are you OK= > =20 > > with that? > >=20 > > --=20 > > Yao Qi > > +proc dwarf2_support {} { > + if {![istarget *-*-linux*] > + && ![istarget *-*-gnu*] > + && ![istarget *-*-elf*] > + && ![istarget *-*-openbsd*] > + && ![istarget arm*-*-eabi*] > + && ![istarget arm*-*-symbianelf*] > + && ![istarget powerpc-*-eabi*]} { > + return 0 > + } > + > + return 1 > +} > > Why is this negated? It would seem more sensible to me to have a list > of supported targets that returns 1 and then default to returning 0 for > everything else. Why? Because then if the list gets too long its > easier to add a second cluster in an independent if-clause. Agreed, it seems more maintainable to have this as a positive list. > The ARM bits are all fine. The dwarf2 changes look generally sensible, > but should be reviewed by a full gdb maintainer, which I'm not. I think the general bits were already approved by Pedro a while back. Yao, please apply (with the change Richard suggested). Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com