[patch] OpenCL testsuite fix

[patch] OpenCL testsuite fix

[Ken Werner]

[-- Attachment #1: Type: Text/Plain, Size: 293 bytes --]

Hi,

The attached patch adds the missing compile_flags argument to the 
gdb_compile_opencl_hostapp call in the skip_opencl_tests procedure. This 
prevents `make check` from printing error messages if there is no OpenCL 
environment available (i.e. missing opencl.h).
Ok to apply?

Regards
Ken

[-- Attachment #2: opencl-testsuite.patch --]
[-- Type: text/x-patch, Size: 979 bytes --]

gdb/testsuite/ChangeLog

2011-01-21  Ken Werner  <ken.werner@de.ibm.com>

	* lib/opencl.exp (skip_opencl_tests): Add missing compile_flags
	argument to the gdb_compile_opencl_hostapp call.

Index: gdb/testsuite/lib/opencl.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/opencl.exp,v
retrieving revision 1.1
diff -p -u -r1.1 opencl.exp
--- gdb/testsuite/lib/opencl.exp	5 Nov 2010 14:31:30 -0000	1.1
+++ gdb/testsuite/lib/opencl.exp	21 Jan 2011 11:24:30 -0000
@@ -50,7 +50,7 @@ proc skip_opencl_tests {} {
     verbose "$me:  compiling OpenCL test app" 2
     set compile_flags {debug nowarnings quiet}
 
-    if { [gdb_compile_opencl_hostapp "${clprogram}" "${executable}" "" ] != "" } {
+    if { [gdb_compile_opencl_hostapp "${clprogram}" "${executable}" "${compile_flags}" ] != "" } {
         verbose "$me:  compiling OpenCL binary failed, returning 1" 2
 	return [set skip_opencl_tests_saved($board) 1]
     }

Re: [patch] OpenCL testsuite fix

[Ulrich Weigand]

Ken Werner wrote:

> 	* lib/opencl.exp (skip_opencl_tests): Add missing compile_flags
> 	argument to the gdb_compile_opencl_hostapp call.

This is OK.

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com

Re: [patch] OpenCL testsuite fix

[Ken Werner]

On Friday, January 21, 2011 1:41:49 pm Ulrich Weigand wrote:
> Ken Werner wrote:
> > 	* lib/opencl.exp (skip_opencl_tests): Add missing compile_flags
> > 	argument to the gdb_compile_opencl_hostapp call.
> 
> This is OK.

Patch applied:
http://sourceware.org/ml/gdb-cvs/2011-01/msg00146.html

Thanks
Ken