[patch] Fix DWARF-3+ DW_AT_accessibility default assumption

[patch] Fix DWARF-3+ DW_AT_accessibility default assumption

[Jan Kratochvil]

Hi,

GDB regresses on default compiler option -gdwarf-3 on gcc-4.6+ as this gcc
started to omit DW_AT_accessibility for the default value case.  Normal
upstream gcc still has -gdwarf-2 default (Fedora uses -gdwarf-3 default).

No regressions on {x86_64,x86_64-m32,i686}-fedora15-linux-gnu.
(There are other regressions to be fixed due to gcc45->gcc46.)

I will check it in in some time.


Thanks,
Jan


-FAIL: gdb.cp/casts.exp: dynamic_cast simple downcast
-FAIL: gdb.cp/casts.exp: dynamic_cast simple downcast to intermediate class
-FAIL: gdb.cp/casts.exp: dynamic_cast unique downcast
-FAIL: gdb.cp/casts.exp: dynamic_cast to sibling
-FAIL: gdb.cp/classes.exp: ptype class default_private_class // wrong access specifier for field: public
-FAIL: gdb.cp/classes.exp: ptype class explicit_private_class // wrong access specifier for field: public
-FAIL: gdb.cp/classes.exp: ptype class mixed_protection_class // wrong access specifier for field: public
-FAIL: gdb.cp/virtfunc.exp: ptype A // wrong access specifier for field: public
-FAIL: gdb.cp/virtfunc.exp: ptype B // wrong access specifier for field: public
-FAIL: gdb.cp/virtfunc.exp: ptype a // wrong access specifier for field: public
-FAIL: gdb.cp/virtfunc.exp: ptype b // wrong access specifier for field: public
-FAIL: gdb.cp/virtfunc.exp: ptype pAa // wrong access specifier for field: public
-FAIL: gdb.cp/virtfunc.exp: ptype pAe // wrong access specifier for field: public
-FAIL: gdb.cp/virtfunc.exp: ptype pBe // wrong access specifier for field: public
-FAIL: gdb.mi/gdb792.exp: list children of class A
-FAIL: gdb.mi/gdb792.exp: list children of A.public
-FAIL: gdb.mi/gdb792.exp: list children of A.private
-FAIL: gdb.mi/gdb792.exp: list children of A.protected
-FAIL: gdb.mi/gdb792.exp: list children of A.protected.b
-FAIL: gdb.mi/gdb792.exp: list children of A.protected.b.public
-FAIL: gdb.mi/gdb792.exp: list children of A.protected.b.private
-FAIL: gdb.mi/gdb792.exp: list children of class C
-FAIL: gdb.python/py-value.exp: python print bool(gdb.parse_and_eval('base').dynamic_cast(gdb.lookup_type('Derived').pointer()))


gdb/
2011-01-25  Jan Kratochvil  <jan.kratochvil@redhat.com>

	Fix DWARF-3+ DW_AT_accessibility default assumption.
	* dwarf2read.c (dwarf2_add_field): Fix new_field->accessibility for
	cu->header.version >= 3.

--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -6186,13 +6186,25 @@ dwarf2_add_field (struct field_info *fip, struct die_info *die,
     }
   fip->nfields++;
 
-  /* Handle accessibility and virtuality of field.
-     The default accessibility for members is public, the default
-     accessibility for inheritance is private.  */
-  if (die->tag != DW_TAG_inheritance)
-    new_field->accessibility = DW_ACCESS_public;
+  if (cu->header.version < 3)
+    {
+      /* The default DWARF 2 accessibility for members is public, the default
+	 accessibility for inheritance is private.  */
+
+      if (die->tag != DW_TAG_inheritance)
+	new_field->accessibility = DW_ACCESS_public;
+      else
+	new_field->accessibility = DW_ACCESS_private;
+    }
   else
-    new_field->accessibility = DW_ACCESS_private;
+    {
+      /* DWARF 3 specifies the default accessibility explicitly.  */
+
+      if (die->parent->tag == DW_TAG_class_type)
+	new_field->accessibility = DW_ACCESS_private;
+      else
+	new_field->accessibility = DW_ACCESS_public;
+    }
   new_field->virtuality = DW_VIRTUALITY_none;
 
   attr = dwarf2_attr (die, DW_AT_accessibility, cu);

Re: [patch] Fix DWARF-3+ DW_AT_accessibility default assumption

[Jan Kratochvil]

On Tue, 25 Jan 2011 20:37:48 +0100, Jan Kratochvil wrote:
> GDB regresses on default compiler option -gdwarf-3 on gcc-4.6+ as this gcc
> started to omit DW_AT_accessibility for the default value case.  Normal
> upstream gcc still has -gdwarf-2 default (Fedora uses -gdwarf-3 default).

More info at:
https://bugzilla.redhat.com/show_bug.cgi?id=672157
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45124


Regards,
Jan

Re: [patch] Fix DWARF-3+ DW_AT_accessibility default assumption

[Jan Kratochvil]

On Tue, 25 Jan 2011 20:37:48 +0100, Jan Kratochvil wrote:
> GDB regresses on default compiler option -gdwarf-3 on gcc-4.6+ as this gcc
> started to omit DW_AT_accessibility for the default value case.  Normal
> upstream gcc still has -gdwarf-2 default (Fedora uses -gdwarf-3 default).
[...]
> I will check it in in some time.
[...]
> gdb/
> 2011-01-25  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	Fix DWARF-3+ DW_AT_accessibility default assumption.
> 	* dwarf2read.c (dwarf2_add_field): Fix new_field->accessibility for
> 	cu->header.version >= 3.

Checked in.  Dealing with testsuite results on FSF GDB was difficult.
	http://sourceware.org/ml/gdb-cvs/2011-03/msg00115.html


Thanks,
Jan

revert: Re: [patch] Fix DWARF-3+ DW_AT_accessibility default assumption

[Jan Kratochvil]

On Tue, 08 Mar 2011 18:55:50 +0100, Jan Kratochvil wrote:
> Checked in.  Dealing with testsuite results on FSF GDB was difficult.
> 	http://sourceware.org/ml/gdb-cvs/2011-03/msg00115.html

Reverted.  It broke compatibility with `gcc-4.5 -gdwarf-3'.

gcc-4.5 violates DWARF:
 <1><2d>: Abbrev Number: 2 (DW_TAG_class_type)
    <2e>   DW_AT_name        : C        
    <30>   DW_AT_byte_size   : 4        
 <2><37>: Abbrev Number: 3 (DW_TAG_member)
    <38>   DW_AT_name        : (indirect string, offset: 0x0): public_  
    <3e>   DW_AT_type        : <0x44>   
    <42>   DW_AT_data_member_location: 0        

DWARF-4 specifies:
An inheritance entry may have a DW_AT_accessibility attribute. If no
accessibility attribute is present, private access is assumed for an entry of a
class and public access is assumed for an entry of an interface, struct or
union.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45124


There will probably need to be a DW_AT_producer check.


Sorry,
Jan


http://sourceware.org/ml/gdb-cvs/2011-03/msg00128.html

--- src/gdb/ChangeLog	2011/03/09 06:24:05	1.12775
+++ src/gdb/ChangeLog	2011/03/09 07:07:53	1.12776
@@ -1,3 +1,11 @@
+2011-03-09  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	Revert:
+	2011-03-08  Jan Kratochvil  <jan.kratochvil@redhat.com>
+	Fix DWARF-3+ DW_AT_accessibility default assumption.
+	* dwarf2read.c (dwarf2_add_field): Fix new_field->accessibility for
+	cu->header.version >= 3.
+
 2011-03-09  Yao Qi  <yao@codesourcery.com>
 
 	* common/Makefile.in: Remove.
--- src/gdb/dwarf2read.c	2011/03/08 17:54:44	1.507
+++ src/gdb/dwarf2read.c	2011/03/09 07:07:55	1.508
@@ -6238,25 +6238,13 @@
     }
   fip->nfields++;
 
-  if (cu->header.version < 3)
-    {
-      /* The default DWARF 2 accessibility for members is public, the default
-	 accessibility for inheritance is private.  */
-
-      if (die->tag != DW_TAG_inheritance)
-	new_field->accessibility = DW_ACCESS_public;
-      else
-	new_field->accessibility = DW_ACCESS_private;
-    }
+  /* Handle accessibility and virtuality of field.
+     The default accessibility for members is public, the default
+     accessibility for inheritance is private.  */
+  if (die->tag != DW_TAG_inheritance)
+    new_field->accessibility = DW_ACCESS_public;
   else
-    {
-      /* DWARF 3 specifies the default accessibility explicitly.  */
-
-      if (die->parent->tag == DW_TAG_class_type)
-	new_field->accessibility = DW_ACCESS_private;
-      else
-	new_field->accessibility = DW_ACCESS_public;
-    }
+    new_field->accessibility = DW_ACCESS_private;
   new_field->virtuality = DW_VIRTUALITY_none;
 
   attr = dwarf2_attr (die, DW_AT_accessibility, cu);

reposted: Re: revert: Re: [patch] Fix DWARF-3+ DW_AT_accessibility default assumption

[Jan Kratochvil]

repost in a new thread:
	[patch] DWARF-3+ DW_AT_accessibility defaults #2 (GCC PR debug/45124)
	http://sourceware.org/ml/gdb-patches/2011-03/msg00956.html