From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21843 invoked by alias); 28 Jan 2011 16:01:03 -0000 Received: (qmail 21833 invoked by uid 22791); 28 Jan 2011 16:01:03 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Jan 2011 16:00:56 +0000 Received: (qmail 29734 invoked from network); 28 Jan 2011 16:00:54 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 28 Jan 2011 16:00:54 -0000 To: gdb-patches@sourceware.org Subject: [ob] No need to restore shadows if we haven't read anything. From: Pedro Alves Date: Fri, 28 Jan 2011 16:01:00 -0000 MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201101281600.52448.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00551.txt.bz2 Applied. -- Pedro Alves 2011-01-28 Pedro Alves gdb/ * target.c (memory_xfer_partial): No need to restore shadows if we haven't read anything. --- gdb/target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: src/gdb/target.c =================================================================== --- src.orig/gdb/target.c 2011-01-19 18:26:47.371219996 +0000 +++ src/gdb/target.c 2011-01-28 15:55:11.697137000 +0000 @@ -1414,7 +1414,7 @@ memory_xfer_partial (struct target_ops * } while (ops != NULL); - if (readbuf && !show_memory_breakpoints) + if (res > 0 && readbuf != NULL && !show_memory_breakpoints) breakpoint_restore_shadows (readbuf, memaddr, reg_len); /* Make sure the cache gets updated no matter what - if we are writing