From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: FYI: add user_breakpoint_p
Date: Mon, 31 Jan 2011 02:10:00 -0000 [thread overview]
Message-ID: <20110131020543.GB2384@adacore.com> (raw)
In-Reply-To: <m362t9lpix.fsf@fleche.redhat.com>
> 2011-01-27 Tom Tromey <tromey@redhat.com>
>
> * breakpoint.h (user_breakpoint_p): Declare.
> * breakpoint.c (user_breakpoint_p): New function.
> (breakpoint_1): Use it.
> (save_breakpoints): Likewise.
I love these little cleanups :-).
Just one question about style:
> - if (!user_settable_breakpoint (tp) || tp->number < 0)
> + if (! user_breakpoint_p (tp))
Do we agree on whether to write this as the above, or whether we should
not have a space between the '!' and the expression being negated:
if (! user_breakpoint_p (tp))
?
I did a rough count, and currently we have a bout 500 instance with the
space, and 2800 without...
--
Joel
next prev parent reply other threads:[~2011-01-31 2:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 5:52 Tom Tromey
2011-01-31 2:10 ` Joel Brobecker [this message]
2011-01-31 15:11 ` Tom Tromey
2011-02-01 3:05 ` Joel Brobecker
2011-02-01 14:31 ` Tom Tromey
2011-02-01 15:21 ` Pedro Alves
2011-02-02 14:42 ` Tom Tromey
2011-02-03 4:59 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110131020543.GB2384@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).