From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10259 invoked by alias); 31 Jan 2011 02:05:56 -0000 Received: (qmail 10221 invoked by uid 22791); 31 Jan 2011 02:05:54 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 31 Jan 2011 02:05:50 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 151D82BABDB; Sun, 30 Jan 2011 21:05:49 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Vhkxr+5DK6bp; Sun, 30 Jan 2011 21:05:49 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A59DE2BAB71; Sun, 30 Jan 2011 21:05:48 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 8915E1459BF; Mon, 31 Jan 2011 06:05:43 +0400 (RET) Date: Mon, 31 Jan 2011 02:10:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: FYI: add user_breakpoint_p Message-ID: <20110131020543.GB2384@adacore.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00572.txt.bz2 > 2011-01-27 Tom Tromey > > * breakpoint.h (user_breakpoint_p): Declare. > * breakpoint.c (user_breakpoint_p): New function. > (breakpoint_1): Use it. > (save_breakpoints): Likewise. I love these little cleanups :-). Just one question about style: > - if (!user_settable_breakpoint (tp) || tp->number < 0) > + if (! user_breakpoint_p (tp)) Do we agree on whether to write this as the above, or whether we should not have a space between the '!' and the expression being negated: if (! user_breakpoint_p (tp)) ? I did a rough count, and currently we have a bout 500 instance with the space, and 2800 without... -- Joel