From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27887 invoked by alias); 31 Jan 2011 04:44:13 -0000 Received: (qmail 27875 invoked by uid 22791); 31 Jan 2011 04:44:13 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 31 Jan 2011 04:44:08 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6A4482BABDF; Sun, 30 Jan 2011 23:44:06 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id clFa2iS90lmr; Sun, 30 Jan 2011 23:44:06 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 07DCC2BABDC; Sun, 30 Jan 2011 23:44:05 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id DA9A81459BF; Mon, 31 Jan 2011 08:44:00 +0400 (RET) Date: Mon, 31 Jan 2011 04:50:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 2/2] allow building GDB with Python support on MinGW Message-ID: <20110131044400.GF2384@adacore.com> References: <1295739863-1006-1-git-send-email-brobecker@adacore.com> <1295739863-1006-3-git-send-email-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00578.txt.bz2 >> gdb/ChangeLog: >> >> * configure.ac: Add handling of Python distribution on Windows. >> * python-config.py: If the LIBS, SYSLIBS, LIBPL and/or LINKFORSHARED >> sysconfig variables are not defined, then do not use them. >> On Windows, if LIBPL is not defined, then use prefix + '/libs' >> instead. On Windows, return all paths using forward-slashes >> rather than backslashes. > FWIW, it seems reasonable to me, though I think you should self-approve > on the basis that you know more about python-config.py than anybody else :-) Thanks! I appreciate the review, though, because of the changes in configure.ac... Checked in. -- Joel