From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15387 invoked by alias); 1 Feb 2011 03:05:59 -0000 Received: (qmail 15371 invoked by uid 22791); 1 Feb 2011 03:05:58 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Feb 2011 03:05:53 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 62F0C2BAC3D; Mon, 31 Jan 2011 22:05:51 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ke-eA3JjFmKG; Mon, 31 Jan 2011 22:05:51 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id F09B42BABB1; Mon, 31 Jan 2011 22:05:50 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 199F61459BF; Tue, 1 Feb 2011 07:05:44 +0400 (RET) Date: Tue, 01 Feb 2011 03:05:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: FYI: add user_breakpoint_p Message-ID: <20110201030544.GH2384@adacore.com> References: <20110131020543.GB2384@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00000.txt.bz2 > >> - if (!user_settable_breakpoint (tp) || tp->number < 0) > >> + if (! user_breakpoint_p (tp)) > > Joel> Do we agree on whether to write this as the above, or whether we should > Joel> not have a space between the '!' and the expression being negated: > > I have trouble remembering whether we have a rule here. > I will remove the space. It doesn't matter to me either way if we have > it or not. It doesn't matter to me either way, althought I have a slight preference for no space. I'd like us to agree and make a "soft" recommendation on my wiki page about the GDB Coding Style. -- Joel