From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25428 invoked by alias); 28 Feb 2011 15:23:24 -0000 Received: (qmail 25419 invoked by uid 22791); 28 Feb 2011 15:23:23 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate6.uk.ibm.com (HELO mtagate6.uk.ibm.com) (194.196.100.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 Feb 2011 15:23:18 +0000 Received: from d06nrmr1707.portsmouth.uk.ibm.com (d06nrmr1707.portsmouth.uk.ibm.com [9.149.39.225]) by mtagate6.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p1SFNFDP025072 for ; Mon, 28 Feb 2011 15:23:15 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p1SFNQUM1978474 for ; Mon, 28 Feb 2011 15:23:26 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p1SFNEj5022563 for ; Mon, 28 Feb 2011 08:23:15 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id p1SFNDdE022526; Mon, 28 Feb 2011 08:23:13 -0700 Message-Id: <201102281523.p1SFNDdE022526@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 28 Feb 2011 16:23:13 +0100 Subject: Re: [rfc] More intelligent indenting of multi-line table entries (Re: [RFA] Implement support for PowerPC BookE ranged breakpoin To: pedro@codesourcery.com (Pedro Alves) Date: Mon, 28 Feb 2011 15:33:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, bauerman@br.ibm.com (Thiago Jung Bauermann) In-Reply-To: <201102251444.17070.pedro@codesourcery.com> from "Pedro Alves" at Feb 25, 2011 02:44:16 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00897.txt.bz2 Pedro Alves wrote: > On Thursday 24 February 2011 20:41:12, Ulrich Weigand wrote: > > My thought was to remove that redundancy completely, and simply > > ask the UI table layer for the correct position. It turns out > > that this needs some new functionality exported from that layer, > > but a simply query for the field information you originally > > passed to that layer suffices. > >=20 > > The following patch implements this suggestion; it fixes the currently > > broken indentation and gets rid of the silly arguments to the > > print_breakpoint_location function. > >=20 > > Tested on i386-linux and by manual inspection of line wrapping. > >=20 > > Any comments? > > Looks great to me. Thanks for the review! I've checked this in now. > I've mentioned this before, but I think it'd really be nice > that the table layout support was reworked to be able to auto > wrap (and size perhaps) columns nicely, =E0 la emacs' org-mode, > vis: > > | Num | Name | What | Other column | > |-----+--------------+----------+--------------| > | 1 | foo bar | foo | another | > | | | bar what | broken | > | | | | sentence | > |-----+--------------+----------+--------------| > | 2 | the other | what? | yummy | > > so that all colums would line-break nicely without > messing their rightmost columns. (without the guide > lines, of course). Yes, ideally the UI table mode should really automatically lay out the full table. But right now it seems to be used interspersed with regular output commands, so getting there would probably require major changes to the current output generators ... Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com