From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21439 invoked by alias); 28 Feb 2011 16:24:37 -0000 Received: (qmail 21429 invoked by uid 22791); 28 Feb 2011 16:24:36 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate6.uk.ibm.com (HELO mtagate6.uk.ibm.com) (194.196.100.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 Feb 2011 16:24:30 +0000 Received: from d06nrmr1707.portsmouth.uk.ibm.com (d06nrmr1707.portsmouth.uk.ibm.com [9.149.39.225]) by mtagate6.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p1SGOR35013503 for ; Mon, 28 Feb 2011 16:24:27 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p1SGOcnT1347672 for ; Mon, 28 Feb 2011 16:24:38 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p1SGO4lb029427 for ; Mon, 28 Feb 2011 09:24:05 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id p1SGO3Tx029386; Mon, 28 Feb 2011 09:24:03 -0700 Message-Id: <201102281624.p1SGO3Tx029386@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 28 Feb 2011 17:24:03 +0100 Subject: [commit] Remove unused parameter (Re: [rfc] More intelligent indenting of multi-line table entries) To: gdb-patches@sourceware.org Date: Mon, 28 Feb 2011 16:34:00 -0000 From: "Ulrich Weigand" Cc: pedro@codesourcery.com (Pedro Alves), bauerman@br.ibm.com (Thiago Jung Bauermann) In-Reply-To: <201102281523.p1SFNDdE022526@d06av02.portsmouth.uk.ibm.com> from "Ulrich Weigand" at Feb 28, 2011 04:23:13 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00911.txt.bz2 Hello, I've checked in the following patch as well. The PRINT_ADDRESS_BITS parameter is now unused in print_one_breakpoint_location and therefore print_one_breakpoint, so it should be removed. Bye, Ulrich ChangeLog: * breakpoint.c (print_one_breakpoint_location): Remove unused argument PRINT_ADDRESS_BITS. Update callers. (print_one_breakpoint): Likewise. Index: gdb/breakpoint.c =================================================================== RCS file: /cvs/src/src/gdb/breakpoint.c,v retrieving revision 1.543 diff -u -p -r1.543 breakpoint.c --- gdb/breakpoint.c 28 Feb 2011 15:21:21 -0000 1.543 +++ gdb/breakpoint.c 28 Feb 2011 16:17:16 -0000 @@ -4708,7 +4708,6 @@ print_one_breakpoint_location (struct br struct bp_location *loc, int loc_number, struct bp_location **last_loc, - int print_address_bits, int allflag) { struct command_line *l; @@ -4999,11 +4998,9 @@ print_one_breakpoint_location (struct br static void print_one_breakpoint (struct breakpoint *b, struct bp_location **last_loc, - int print_address_bits, int allflag) { - print_one_breakpoint_location (b, NULL, 0, last_loc, - print_address_bits, allflag); + print_one_breakpoint_location (b, NULL, 0, last_loc, allflag); /* If this breakpoint has custom print function, it's already printed. Otherwise, print individual @@ -5025,8 +5022,7 @@ print_one_breakpoint (struct breakpoint struct bp_location *loc; int n = 1; for (loc = b->loc; loc; loc = loc->next, ++n) - print_one_breakpoint_location (b, loc, n, last_loc, - print_address_bits, allflag); + print_one_breakpoint_location (b, loc, n, last_loc, allflag); } } } @@ -5070,9 +5066,7 @@ do_captured_breakpoint_query (struct ui_ { if (args->bnum == b->number) { - int print_address_bits = breakpoint_address_bits (b); - - print_one_breakpoint (b, &dummy_loc, print_address_bits, 0); + print_one_breakpoint (b, &dummy_loc, 0); return GDB_RC_OK; } } @@ -5243,7 +5237,7 @@ breakpoint_1 (char *args, int allflag, /* We only print out user settable breakpoints unless the allflag is set. */ if (allflag || user_breakpoint_p (b)) - print_one_breakpoint (b, &last_loc, print_address_bits, allflag); + print_one_breakpoint (b, &last_loc, allflag); } do_cleanups (bkpttbl_chain); -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com