From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28463 invoked by alias); 7 Mar 2011 10:52:26 -0000 Received: (qmail 28455 invoked by uid 22791); 7 Mar 2011 10:52:26 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Mar 2011 10:52:22 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3F0172BAE1A for ; Mon, 7 Mar 2011 05:52:21 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 3Ez9MyRw0+Bm for ; Mon, 7 Mar 2011 05:52:21 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id CF5932BADAD for ; Mon, 7 Mar 2011 05:52:20 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 2BD271459AD; Mon, 7 Mar 2011 14:51:58 +0400 (RET) Date: Mon, 07 Mar 2011 11:07:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: can we avoid using contractions in GDB messages? (was: "[commit] symfile.c (simple_overlay_update): Check for null return.") Message-ID: <20110307105158.GZ30306@adacore.com> References: <4D718A22.3020302@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D718A22.3020302@vmware.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00442.txt.bz2 Just a suggestion. It's really a detail, and I won't push for us to adopt this suggestion, but: > + if (minsym == NULL) > + error (_("Error reading inferior's overlay table: couldn't " > + "find `_ovly_table' array\n" > + "in inferior. Use `overlay manual' mode.")); I'm not very fond of contractions in error messages (or any message printed by GDB). I know there is plenty of "prior art" of our use of contractions in the output, but I just think it looks better to spell words completely. For the future, can we agree on avoiding contractions? -- Joel