From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4751 invoked by alias); 14 Mar 2011 13:53:22 -0000 Received: (qmail 4724 invoked by uid 22791); 14 Mar 2011 13:53:20 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Mar 2011 13:53:15 +0000 Received: (qmail 16436 invoked from network); 14 Mar 2011 13:53:13 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 14 Mar 2011 13:53:13 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] make first parameter of to_lookup_symbol const char * Date: Mon, 14 Mar 2011 14:03:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-27-generic; KDE/4.6.1; x86_64; ; ) Cc: Tristan Gingold References: <58CFFAD9-1C02-4AD8-B416-FC48D1A7F006@adacore.com> In-Reply-To: <58CFFAD9-1C02-4AD8-B416-FC48D1A7F006@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201103141353.10512.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00726.txt.bz2 On Monday 14 March 2011 10:13:43, Tristan Gingold wrote: > is there any good reason why the NAME parameter is 'char *' instead of 'const char *' ? I can't see any of them. Old code. Original K&R didn't know about const. We have a lot of places that could/should be const but aren't. It's an ongoing slow cleanup. > > This patch was tested only by recompiling gdb for powerpc-elf. > > BTW, it looks like no target defines this operation... Are you going to add a use of it? Otherwise, I'd rather just getting rid of it. > > Tristan. > > 2011-03-14 Tristan Gingold > > * target.h (target_ops): Make NAME parameter of to_lookup_symbol > const char* > * target.c (debug_to_lookup_symbol): Constify NAME parameter. > Adjust prototype. > (update_current_target): Adjust. > > diff --git a/gdb/target.c b/gdb/target.c > index c155716..0e6d652 100644 > --- a/gdb/target.c > +++ b/gdb/target.c > @@ -151,7 +151,7 @@ static void debug_to_load (char *, int); > > static void debug_to_unload (char *, int); > > -static int debug_to_lookup_symbol (char *, CORE_ADDR *); > +static int debug_to_lookup_symbol (const char *, CORE_ADDR *); > > static int debug_to_can_run (void); > > @@ -781,7 +781,7 @@ update_current_target (void) > (void (*) (char *, int)) > tcomplain); > de_fault (to_lookup_symbol, > - (int (*) (char *, CORE_ADDR *)) > + (int (*) (const char *, CORE_ADDR *)) > nosymbol); > de_fault (to_post_startup_inferior, > (void (*) (ptid_t)) > @@ -3679,7 +3679,7 @@ debug_to_unload (char *args, int from_tty) > } > > static int > -debug_to_lookup_symbol (char *name, CORE_ADDR *addrp) > +debug_to_lookup_symbol (const char *name, CORE_ADDR *addrp) > { > int retval; > > diff --git a/gdb/target.h b/gdb/target.h > index b8db4bc..2318b9d 100644 > --- a/gdb/target.h > +++ b/gdb/target.h > @@ -478,7 +478,7 @@ struct target_ops > void (*to_kill) (struct target_ops *); > void (*to_load) (char *, int); > void (*to_unload) (char *, int); > - int (*to_lookup_symbol) (char *, CORE_ADDR *); > + int (*to_lookup_symbol) (const char *, CORE_ADDR *); > void (*to_create_inferior) (struct target_ops *, > char *, char *, char **, int); > void (*to_post_startup_inferior) (ptid_t); > > -- Pedro Alves