From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9530 invoked by alias); 24 Apr 2011 15:07:40 -0000 Received: (qmail 9522 invoked by uid 22791); 24 Apr 2011 15:07:39 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_XF,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 24 Apr 2011 15:07:19 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3OF7Ju0013624 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 24 Apr 2011 11:07:19 -0400 Received: from host1.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p3OF7Hf0009784 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 24 Apr 2011 11:07:19 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p3OF7HaD005983 for ; Sun, 24 Apr 2011 17:07:17 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p3OF7GVO005982 for gdb-patches@sourceware.org; Sun, 24 Apr 2011 17:07:16 +0200 Date: Sun, 24 Apr 2011 15:07:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: [patch] testcase: PR 8210 corefiles threads #3 Message-ID: <20110424150716.GA5637@host1.jankratochvil.net> References: <20110130191128.GA21123@host1.dyn.jankratochvil.net> <20110419204352.GA10615@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110419204352.GA10615@host1.jankratochvil.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00432.txt.bz2 Hi, the testcase originally submitted did not catch a failure in BFD resulting in the output: p/x thread0 $1 = 0xfff2210 p/x thread1 $2 = 0xf7fef4c0 info threads 3 Thread 0xfff2210 (LWP 1) warning: Couldn't find general-purpose registers in core file. 0x00000000 in ?? () 2 Thread 26859 0x0ff02698 in clone () from /lib/power6/libc.so.6 * 1 Thread 0xf7fef4c0 (LWP 26860) 0x0fe45e40 in raise () from /lib/power6/libc.so.6 (gdb) _ As both thread ids are present there in this case but apparently the output is not correct. (This output is from gdb-7.0.1-37.el5 on powerpc64-linux-gnu, the testcase needs to be different there a bit). The testcase now requires exactly two lines and only threads 1 and 2. Thanks, Jan On Tue, 19 Apr 2011 22:43:52 +0200, Jan Kratochvil wrote: the testcase originally submitted did not work with FSF GDB as it was based on gcore which does not provide enough prstatus/prpsinfo info in the core files and which are fixed by Denys Vlasenko's off-trunk patch: http://pkgs.fedoraproject.org/gitweb/?p=gdb.git;a=blob_plain;f=gdb-6.8-bz254229-gcore-prpsinfo.patch;hb=f15/master Therefore this testcase uses native kernel core dumping instead. No regressions on {x86_64,x86_64-m32,i686}-fedora15-linux-gnu. And also on ppc64-m64, ppc64-m32, s390x, s390 and ia64 (some having a bfd/ dependency to be posted now). On Sun, 30 Jan 2011 20:11:28 +0100, Jan Kratochvil wrote: PR 8210 did not provide a new testcase, here it is. I have limited the check only to *-*-linux* as other targets seem to identify the thread differently (untested outside of GNU/Linux). I will check it in after a while, it seems safe to me. gdb/testsuite/ 2011-04-24 Jan Kratochvil * gdb.threads/corethreads.c: New file. * gdb.threads/corethreads.exp: New file. --- /dev/null +++ b/gdb/testsuite/gdb.threads/corethreads.c @@ -0,0 +1,47 @@ +/* Copyright 2011 Free Software Foundation, Inc. + + This file is part of GDB. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +#include +#include +#include + +pthread_t thread0; +pthread_t thread1; + +static void * +start (void *arg) +{ + assert (pthread_self () == thread1); + + abort (); +} + +int +main (void) +{ + int i; + + thread0 = pthread_self (); + + i = pthread_create (&thread1, NULL, start, NULL); + assert (i == 0); + + i = pthread_join (thread1, NULL); + assert (i == 0); + + return 0; +} --- /dev/null +++ b/gdb/testsuite/gdb.threads/corethreads.exp @@ -0,0 +1,58 @@ +# Copyright 2011 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Are we on a target board? And non-Linux targets seem to identify the thread +# differently. +if {![isnative] || ![istarget "*-*-linux*"]} { + return +} + +set testfile "corethreads" +set srcfile ${testfile}.c +set executable ${testfile} +set binfile ${objdir}/${subdir}/${executable} +if { [gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } { + untested ${testfile}.exp + return -1 +} + +set corefile [core_find $binfile] +if {$corefile == ""} { + return 0 +} + +clean_restart $executable + +gdb_test "core-file $corefile" "Core was generated by .*" "load core" +gdb_test "info files" "\r\nLocal core dump file:\r\n.*" "sanity check we see the core file" + +set test "print pthread_t of thread0" +gdb_test_multiple "p/x thread0" $test { + -re " = (0x\[0-9a-f\]+)\r\n$gdb_prompt $" { + pass $test + set thread0 $expect_out(1,string) + } +} +set test "print pthread_t of thread1" +gdb_test_multiple "p/x thread1" $test { + -re " = (0x\[0-9a-f\]+)\r\n$gdb_prompt $" { + pass $test + set thread1 $expect_out(1,string) + } +} + +gdb_test "info threads" "\r\n *\[12\] +Thread $thread0 .*" "thread0 found" +gdb_test "info threads" "\r\n *\\*? +\[12\] +Thread $thread1 .*" "thread1 found" +gdb_test "info threads" "\r\n\[ \t\]*Id\[ \t\]+Target\[ \t\]+Id\[ \t\]+Frame\[ \t\]*\r\n\[^\r\n\]+\r\n\[^\r\n\]+" "no other thread found"