public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [obv] gdb.reverse/i386-sse-reverse.exp: gdb_expect cleanup
@ 2011-11-25 23:58 Jan Kratochvil
  0 siblings, 0 replies; only message in thread
From: Jan Kratochvil @ 2011-11-25 23:58 UTC (permalink / raw)
  To: gdb-patches

Hi,

gdb_expect does not handle various corner cases.  gdb_test_multiple does.

Checked in.  It should have no functionality change in normal cases.


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2011-11/msg00159.html

--- src/gdb/testsuite/ChangeLog	2011/11/25 23:50:13	1.2947
+++ src/gdb/testsuite/ChangeLog	2011/11/25 23:53:44	1.2948
@@ -4,6 +4,10 @@
 	* gdb.reverse/i386-sse-reverse.exp (continue to end of sse_test #2):
 	Wrap send_gdb into a new gdb_test.
 
+	Code cleanup.
+	* gdb.reverse/i386-sse-reverse.exp (continue to end of sse4_test):
+	Convert send_gdb and gdb_expect to gdb_test_multiple.
+
 2011-11-25  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
 	* gdb.base/jit-so.exp (one_jit_test): Add testcase name to log message.
--- src/gdb/testsuite/gdb.reverse/i386-sse-reverse.exp	2011/11/25 23:50:15	1.7
+++ src/gdb/testsuite/gdb.reverse/i386-sse-reverse.exp	2011/11/25 23:53:45	1.8
@@ -632,12 +632,12 @@
     "Breakpoint $decimal at .* line $end_sse4_test\." \
     "set breakpoint at end of sse4_test"
 
-send_gdb "continue\n"
-gdb_expect {
-    -re " end sse4_test .*" {
-	pass "continue to end of sse4_test"
+set test "continue to end of sse4_test"
+gdb_test_multiple "continue" $test {
+    -re " end sse4_test .*\r\n$gdb_prompt $" {
+	pass $test
     }
-    -re " Illegal instruction.*" {
+    -re " Illegal instruction.*\r\n$gdb_prompt $" {
 	untested i386-sse4-reverse
         return -1
     }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-11-25 23:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-25 23:58 [obv] gdb.reverse/i386-sse-reverse.exp: gdb_expect cleanup Jan Kratochvil

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).