From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20313 invoked by alias); 28 Nov 2011 18:10:48 -0000 Received: (qmail 20300 invoked by uid 22791); 28 Nov 2011 18:10:47 -0000 X-SWARE-Spam-Status: No, hits=-0.8 required=5.0 tests=AWL,BAYES_20 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 Nov 2011 18:10:31 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1RV5ew-0003Su-IM from pedro_alves@mentor.com for gdb-patches@sourceware.org; Mon, 28 Nov 2011 10:10:30 -0800 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 28 Nov 2011 18:10:29 +0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFC/WIP PATCH 00/14] I/T sets Date: Mon, 28 Nov 2011 18:10:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-12-generic; KDE/4.7.2; x86_64; ; ) References: <20111128153742.17761.21459.stgit@localhost6.localdomain6> In-Reply-To: <20111128153742.17761.21459.stgit@localhost6.localdomain6> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201111281810.27154.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00779.txt.bz2 On Monday 28 November 2011 15:38:53, Pedro Alves wrote: > This series is also available at http://github.com/palves/gdb/tree/itsets-v1 > for convenience. Whoops, I've just noticed that the series I posted is badly broken due to a last minute change. I've just pushed the commit below there to fix it, and will fold it into the proper place in for v2. Sorry about that. -- Pedro Alves commit 0103de5e1e88bab2050a19abc51c92fd3d3898d0 Author: Pedro Alves Date: Mon Nov 28 18:02:14 2011 +0000 Allow calling itset_reference on a NULL itset. We'll just return a NULL itset then. (top-gdb) bt #0 0x00000000006a4811 in itset_reference (itset=0x0) at ../../gdb/gdb/itset.c:1532 #1 0x000000000052f87d in bpstat_stop_set (bs_head=0x1461ad0) at ../../gdb/gdb/breakpoint.c:4559 #2 0x00000000005a09eb in handle_inferior_event (ecs=0x7fff568abc00) at ../../gdb/gdb/infrun.c:5183 diff --git a/gdb/itset.c b/gdb/itset.c index 717d261..25e40b6 100644 --- a/gdb/itset.c +++ b/gdb/itset.c @@ -1529,7 +1529,8 @@ itset_contains_thread (struct itset *set, struct thread_info *thr) struct itset * itset_reference (struct itset *itset) { - ++itset->refc; + if (itset) + ++itset->refc; return itset; }