From: Pedro Alves <pedro@codesourcery.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] PR threads/10729: x86 hw watchpoints and non-stop mode
Date: Tue, 13 Dec 2011 16:26:00 -0000 [thread overview]
Message-ID: <201112131620.28214.pedro@codesourcery.com> (raw)
In-Reply-To: <83iplpmuht.fsf@gnu.org>
On Friday 09 December 2011 19:10:22, Eli Zaretskii wrote:
> My extra pair of eyes spotted this:
>
> > --- a/gdb/go32-nat.c
> > +++ b/gdb/go32-nat.c
> > @@ -801,6 +801,28 @@ go32_get_dr6 (void)
> > return STATUS;
> > }
> >
> > +/* Get the value of the DR6 debug status register from the inferior.
> > + Here we just return the value stored in D_REGS, as we've got it
> > + from the last go32_wait call. */
> > +static unsigned long
> > +go32_get_dr7 (void)
> > +{
> > + return CONTROL;
> > +}
>
> The comment says DR6, but the function uses dr7. I think the comment
> is wrong.
Indeed. I copied the comment from go32_get_dr6, and forgot to adjust.
Fixed now.
> No other comments. Thanks.
Thanks a lot.
--
Pedro Alves
next prev parent reply other threads:[~2011-12-13 16:21 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 16:46 Pedro Alves
2011-12-05 17:06 ` Eli Zaretskii
2011-12-09 16:30 ` New tests to watch regions larger than a machine word (Re: [PATCH] PR threads/10729: x86 hw watchpoints and non-stop mode) Pedro Alves
2011-12-09 19:11 ` Eli Zaretskii
2011-12-13 16:12 ` Pedro Alves
2011-12-05 21:24 ` [PATCH] PR threads/10729: x86 hw watchpoints and non-stop mode Jan Kratochvil
2011-12-09 16:45 ` Pedro Alves
2011-12-09 16:47 ` Tristan Gingold
2011-12-09 19:23 ` Eli Zaretskii
2011-12-13 16:26 ` Pedro Alves [this message]
2011-12-11 23:39 ` Jan Kratochvil
2011-12-12 11:53 ` Pedro Alves
2011-12-12 14:49 ` Jan Kratochvil
2011-12-12 0:14 ` Jan Kratochvil
2011-12-12 17:23 ` Pedro Alves
2011-12-12 18:38 ` Jan Kratochvil
2011-12-12 20:14 ` Jan Kratochvil
2011-12-12 20:30 ` Pedro Alves
2011-12-13 17:24 ` Jan Kratochvil
2011-12-13 18:49 ` Pedro Alves
2011-12-13 19:25 ` Jan Kratochvil
2011-12-16 16:16 ` Pedro Alves
2012-01-20 19:51 ` testsuite: native/non-extended/extended modes [Re: [PATCH] PR threads/10729: x86 hw watchpoints and non-stop mode] Jan Kratochvil
2012-01-20 19:53 ` Pedro Alves
2012-01-20 19:57 ` Jan Kratochvil
2011-12-12 20:34 ` [PATCH] PR threads/10729: x86 hw watchpoints and non-stop mode Pedro Alves
2011-12-12 21:39 ` Jan Kratochvil
2011-12-13 16:21 ` Fix PR remote/13492 (Re: [PATCH] PR threads/10729: x86 hw watchpoints and non-stop mode) Pedro Alves
2011-12-13 17:23 ` Fix PR remote/13492 Jan Kratochvil
2011-12-13 16:33 ` [PATCH] PR threads/10729: x86 hw watchpoints and non-stop mode Pedro Alves
2011-12-13 18:57 ` Jan Kratochvil
2011-12-14 17:35 ` Pedro Alves
2011-12-14 17:42 ` Pedro Alves
2011-12-15 8:48 ` Regression for T (Stopped) processes [Re: [PATCH] PR threads/10729: x86 hw watchpoints and non-stop mode] Jan Kratochvil
2011-12-15 12:44 ` Pedro Alves
2011-12-15 15:33 ` Jan Kratochvil
2011-12-13 22:27 ` [PATCH] PR threads/10729: x86 hw watchpoints and non-stop mode Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112131620.28214.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).