Re: [PATCH] PR threads/10729: x86 hw watchpoints and non-stop mode

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Tue, 13 Dec 2011 17:26:03 +0100, Pedro Alves wrote:
> Anything else I should address?  

I am fine with this patch, thanks.


> Since we just branched, I'm a bit less worried about
> breaking things on other platforms.  :-)
+
>  /* Register a method to call whenever a new thread is attached.  */
>  void
> -linux_nat_set_new_thread (struct target_ops *t, void (*new_thread) (ptid_t))
> +linux_nat_set_new_thread (struct target_ops *t,
> +			  void (*new_thread) (struct lwp_info *))

In such case you should change also all the callers on exotic arches:

./arm-linux-nat.c:1274:  linux_nat_set_new_thread (t, arm_linux_new_thread);
./ia64-linux-nat.c:861:  linux_nat_set_new_thread (t, ia64_linux_new_thread);
./mips-linux-nat.c:1088:  linux_nat_set_new_thread (t, mips_linux_new_thread);
./ppc-linux-nat.c:2530:  linux_nat_set_new_thread (t, ppc_linux_new_thread);
./s390-nat.c:698:  linux_nat_set_new_thread (t, s390_fix_watch_points);


> +     done prior to resume.  Instead, if threads are running when the
> +     mirror changes, a temporary and transparent stop on all threads
> +     is forced so they can get their copy of the debug registers
> +     updated on re-resume.  Now, say, a thread hit a watchpoint before

IMO s/re-resume/their resume/ but I do not master the language.



Thanks,
Jan