From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Paul Hilfinger <Hilfinger@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Have block_innermost_frame start from selected frame
Date: Wed, 28 Dec 2011 15:16:00 -0000 [thread overview]
Message-ID: <20111228130959.GA2885@host2.jankratochvil.net> (raw)
In-Reply-To: <20111227195809.672D892BF6@kwai.gnat.com>
On Tue, 27 Dec 2011 20:58:09 +0100, Paul Hilfinger wrote:
> --- a/gdb/blockframe.c
> +++ b/gdb/blockframe.c
> @@ -370,7 +370,9 @@ block_innermost_frame (const struct block *block)
> start = BLOCK_START (block);
> end = BLOCK_END (block);
>
> - frame = get_current_frame ();
> + frame = get_selected_frame_if_set ();
> + if (frame == NULL)
> + frame = get_current_frame ();
And the comment of this function is no longer valid then:
/* Return the innermost stack frame executing inside of BLOCK, or NULL
if there is no such frame. If BLOCK is NULL, just return NULL. */
struct frame_info *
block_innermost_frame (const struct block *block)
Regards,
Jan
next prev parent reply other threads:[~2011-12-28 13:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-27 19:59 Paul Hilfinger
2011-12-28 13:10 ` Jan Kratochvil
2011-12-28 15:41 ` Joel Brobecker
2011-12-28 16:00 ` Jan Kratochvil
2011-12-28 17:23 ` Joel Brobecker
2011-12-29 20:30 ` Paul Hilfinger
2011-12-29 23:13 ` Jan Kratochvil
2011-12-28 15:16 ` Jan Kratochvil [this message]
2011-12-30 21:54 Paul Hilfinger
2011-12-31 8:58 ` Eli Zaretskii
2011-12-31 21:40 ` Paul Hilfinger
2012-01-09 7:17 ` Paul Hilfinger
2012-01-09 17:14 ` Eli Zaretskii
2012-01-09 19:59 ` Paul Hilfinger
2012-01-10 5:21 ` Joel Brobecker
2012-01-10 10:28 ` Eli Zaretskii
2012-01-10 10:40 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111228130959.GA2885@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=Hilfinger@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).