From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: jan.kratochvil@redhat.com (Jan Kratochvil)
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 2/2] Fix linking on non-x86* after libgdb.a removal
Date: Tue, 10 Jan 2012 16:06:00 -0000 [thread overview]
Message-ID: <201201101602.q0AG2wLg008067@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <20120109210144.GA31823@host2.jankratochvil.net> from "Jan Kratochvil" at Jan 09, 2012 10:01:44 PM
Jan Kratochvil wrote:
> While implementing it I find the current behavior already wrong:
[snip]
> It is also weird the behavior of target X (sparc-solaris2.6; whether the core
> file gets an error or just *value not available* registers) depends on whether
> there are also compiled in unrelated targets Y (x86_64-linux-gnu) or Z.
Yes, fully agreed.
> gdb/
> 2012-01-09 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Fix duplicate .o files after omitting libbfd.a.
> * Makefile.in (ALL_TARGET_OBS): Remove corelow.o.
> (SFILES): Add corelow.c.
> (COMMON_OBS): Add corelow.o.
> (ALLDEPFILES): Remove corelow.c.
> * config/alpha/alpha-linux.mh (NATDEPFILES): Remove corelow.o.
> * config/alpha/alpha-osf3.mh: Likewise.
> * config/alpha/fbsd.mh: Likewise.
> * config/arm/nbsdaout.mh: Likewise.
> * config/arm/nbsdelf.mh: Likewise.
> * config/i386/i386gnu.mh: Likewise.
> * config/ia64/hpux.mh: Likewise.
> * config/ia64/linux.mh: Likewise.
> * config/m32r/linux.mh: Likewise.
> * config/m68k/linux.mh: Likewise.
> * config/mips/irix5.mh: Likewise.
> * config/mips/irix6.mh: Likewise.
> * config/pa/hpux.mh: Likewise.
> * config/pa/linux.mh: Likewise.
> * config/powerpc/aix.mh: Likewise.
> * config/sparc/linux.mh: Likewise.
> * config/sparc/linux64.mh: Likewise.
> * config/sparc/sol2.mh: Likewise.
> * config/vax/vax.mh: Likewise.
> * configure.tgt (alpha*-*-freebsd* alpha*-*-kfreebsd*-gnu)
> (alpha*-*-netbsd*, alpha*-*-knetbsd*-gnu, alpha*-*-openbsd*)
> (am33_2.0*-*-linux*, arm*-wince-pe, arm*-*-mingw32ce*, arm*-*-linux*)
> (arm*-*-openbsd*, cris*, frv-*-*, hppa*-*-hpux*, hppa*-*-netbsd*)
> (hppa*-*-openbsd*, i[34567]86-*-dicos*, i[34567]86-*-freebsd*)
> (i[34567]86-*-kfreebsd*-gnu, i[34567]86-*-netbsd*)
> (i[34567]86-*-knetbsd*-gnu, i[34567]86-*-openbsd*, i[34567]86-*-nto*)
> (i[34567]86-*-solaris2.1[0-9]*, x86_64-*-solaris2.1[0-9]*)
> (i[34567]86-*-solaris*, i[34567]86-*-linux*, i[34567]86-*-cygwin*)
> (i[34567]86-*-mingw32*, m68*-*-netbsd*, m68*-*-knetbsd*-gnu)
> (m68*-*-openbsd*, m88*-*-openbsd*, microblaze*-linux-*)
> (microblaze*-*-linux*, mips*-*-linux*, mips*-*-netbsd*)
> (mips*-*-knetbsd*-gnu, mips64*-*-openbsd*, powerpc-*-netbsd*)
> (powerpc-*-knetbsd*-gnu, powerpc-*-openbsd*, powerpc-*-linux*)
> (powerpc64-*-linux*, s390*-*-*, score-*-*, sh*-*-linux*)
> (sh*-*-netbsdelf*, sh*-*-knetbsd*-gnu, sh*-*-openbsd*)
> (sparc*-*-freebsd*, sparc*-*-kfreebsd*-gnu, sparc-*-netbsd*)
> (sparc-*-knetbsd*-gnu, sparc64-*-netbsd*, sparc64-*-knetbsd*-gnu)
> (sparc-*-openbsd*, sparc64-*-openbsd*, tic6x-*-*linux, vax-*-netbsd*)
> (vax-*-knetbsd*-gnu, vax-*-openbsd*, x86_64-*-dicos*, x86_64-*-linux*)
> (x86_64-*-freebsd*, x86_64-*-kfreebsd*-gnu, x86_64-*-netbsd*)
> (x86_64-*-knetbsd*-gnu, x86_64-*-openbsd*, xtensa*-*-linux*): Remove
> corelow.o from gdb_target_obs.
> * corefile.c (core_target): Update the comment on NULL value.
> (core_file_command): Replace error by gdb_assert on CORE_TARGET.
> * corelow.c (sniff_core_bfd): Call error instead of warning on zero
> MATCHES. Drop YUMMY set on NULL.
> (core_close): Do not call exit_inferior_silent on zero PID. Do not
> reclaim CORE_DATA if it is already NULL.
Looks all good to me.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2012-01-10 16:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 20:43 Jan Kratochvil
2012-01-05 14:46 ` Ulrich Weigand
2012-01-05 15:25 ` Jan Kratochvil
2012-01-05 17:10 ` [commit, s390] Move corelow.o to target config (Re: [patch 2/2] Fix linking on non-x86* after libgdb.a removal) Ulrich Weigand
2012-01-05 17:12 ` [patch 2/2] Fix linking on non-x86* after libgdb.a removal Ulrich Weigand
2012-01-09 21:02 ` Jan Kratochvil
2012-01-10 16:06 ` Ulrich Weigand [this message]
2012-01-10 17:17 ` [commit] " Jan Kratochvil
2012-01-10 19:32 ` Pedro Alves
2012-01-10 19:55 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201101602.q0AG2wLg008067@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).