From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6724 invoked by alias); 10 Jan 2012 16:03:19 -0000 Received: (qmail 6673 invoked by uid 22791); 10 Jan 2012 16:03:17 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e06smtp18.uk.ibm.com (HELO e06smtp18.uk.ibm.com) (195.75.94.114) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Jan 2012 16:03:03 +0000 Received: from /spool/local by e06smtp18.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 10 Jan 2012 16:03:01 -0000 Received: from d06nrmr1407.portsmouth.uk.ibm.com ([9.149.38.185]) by e06smtp18.uk.ibm.com ([192.168.101.148]) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 10 Jan 2012 16:03:00 -0000 Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1407.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q0AG30pA2326540 for ; Tue, 10 Jan 2012 16:03:00 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q0AG2xtE008090 for ; Tue, 10 Jan 2012 09:03:00 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id q0AG2wLg008067; Tue, 10 Jan 2012 09:02:58 -0700 Message-Id: <201201101602.q0AG2wLg008067@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 10 Jan 2012 17:02:58 +0100 Subject: Re: [patch 2/2] Fix linking on non-x86* after libgdb.a removal To: jan.kratochvil@redhat.com (Jan Kratochvil) Date: Tue, 10 Jan 2012 16:06:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20120109210144.GA31823@host2.jankratochvil.net> from "Jan Kratochvil" at Jan 09, 2012 10:01:44 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit x-cbid: 12011016-6892-0000-0000-000000AA669F Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00294.txt.bz2 Jan Kratochvil wrote: > While implementing it I find the current behavior already wrong: [snip] > It is also weird the behavior of target X (sparc-solaris2.6; whether the core > file gets an error or just *value not available* registers) depends on whether > there are also compiled in unrelated targets Y (x86_64-linux-gnu) or Z. Yes, fully agreed. > gdb/ > 2012-01-09 Jan Kratochvil > > Fix duplicate .o files after omitting libbfd.a. > * Makefile.in (ALL_TARGET_OBS): Remove corelow.o. > (SFILES): Add corelow.c. > (COMMON_OBS): Add corelow.o. > (ALLDEPFILES): Remove corelow.c. > * config/alpha/alpha-linux.mh (NATDEPFILES): Remove corelow.o. > * config/alpha/alpha-osf3.mh: Likewise. > * config/alpha/fbsd.mh: Likewise. > * config/arm/nbsdaout.mh: Likewise. > * config/arm/nbsdelf.mh: Likewise. > * config/i386/i386gnu.mh: Likewise. > * config/ia64/hpux.mh: Likewise. > * config/ia64/linux.mh: Likewise. > * config/m32r/linux.mh: Likewise. > * config/m68k/linux.mh: Likewise. > * config/mips/irix5.mh: Likewise. > * config/mips/irix6.mh: Likewise. > * config/pa/hpux.mh: Likewise. > * config/pa/linux.mh: Likewise. > * config/powerpc/aix.mh: Likewise. > * config/sparc/linux.mh: Likewise. > * config/sparc/linux64.mh: Likewise. > * config/sparc/sol2.mh: Likewise. > * config/vax/vax.mh: Likewise. > * configure.tgt (alpha*-*-freebsd* alpha*-*-kfreebsd*-gnu) > (alpha*-*-netbsd*, alpha*-*-knetbsd*-gnu, alpha*-*-openbsd*) > (am33_2.0*-*-linux*, arm*-wince-pe, arm*-*-mingw32ce*, arm*-*-linux*) > (arm*-*-openbsd*, cris*, frv-*-*, hppa*-*-hpux*, hppa*-*-netbsd*) > (hppa*-*-openbsd*, i[34567]86-*-dicos*, i[34567]86-*-freebsd*) > (i[34567]86-*-kfreebsd*-gnu, i[34567]86-*-netbsd*) > (i[34567]86-*-knetbsd*-gnu, i[34567]86-*-openbsd*, i[34567]86-*-nto*) > (i[34567]86-*-solaris2.1[0-9]*, x86_64-*-solaris2.1[0-9]*) > (i[34567]86-*-solaris*, i[34567]86-*-linux*, i[34567]86-*-cygwin*) > (i[34567]86-*-mingw32*, m68*-*-netbsd*, m68*-*-knetbsd*-gnu) > (m68*-*-openbsd*, m88*-*-openbsd*, microblaze*-linux-*) > (microblaze*-*-linux*, mips*-*-linux*, mips*-*-netbsd*) > (mips*-*-knetbsd*-gnu, mips64*-*-openbsd*, powerpc-*-netbsd*) > (powerpc-*-knetbsd*-gnu, powerpc-*-openbsd*, powerpc-*-linux*) > (powerpc64-*-linux*, s390*-*-*, score-*-*, sh*-*-linux*) > (sh*-*-netbsdelf*, sh*-*-knetbsd*-gnu, sh*-*-openbsd*) > (sparc*-*-freebsd*, sparc*-*-kfreebsd*-gnu, sparc-*-netbsd*) > (sparc-*-knetbsd*-gnu, sparc64-*-netbsd*, sparc64-*-knetbsd*-gnu) > (sparc-*-openbsd*, sparc64-*-openbsd*, tic6x-*-*linux, vax-*-netbsd*) > (vax-*-knetbsd*-gnu, vax-*-openbsd*, x86_64-*-dicos*, x86_64-*-linux*) > (x86_64-*-freebsd*, x86_64-*-kfreebsd*-gnu, x86_64-*-netbsd*) > (x86_64-*-knetbsd*-gnu, x86_64-*-openbsd*, xtensa*-*-linux*): Remove > corelow.o from gdb_target_obs. > * corefile.c (core_target): Update the comment on NULL value. > (core_file_command): Replace error by gdb_assert on CORE_TARGET. > * corelow.c (sniff_core_bfd): Call error instead of warning on zero > MATCHES. Drop YUMMY set on NULL. > (core_close): Do not call exit_inferior_silent on zero PID. Do not > reclaim CORE_DATA if it is already NULL. Looks all good to me. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com