From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: add relative file name handling for linespecs
Date: Wed, 11 Jan 2012 09:03:00 -0000 [thread overview]
Message-ID: <20120111045330.GG31383@adacore.com> (raw)
In-Reply-To: <m3d3arlez3.fsf@fleche.redhat.com>
> 2012-01-10 Tom Tromey <tromey@redhat.com>
>
> * NEWS: Add item.
> * symtab.h (compare_filenames_for_search): Declare.
> * symtab.c (compare_filenames_for_search): New function.
> (iterate_over_some_symtabs): Use it.
> * symfile.h (struct quick_symbol_functions)
> <map_symtabs_matching_filename>: Change spec.
> * psymtab.c (partial_map_symtabs_matching_filename): Use
> compare_filenames_for_search. Update for new spec.
> * dwarf2read.c (dw2_map_symtabs_matching_filename): Use
> compare_filenames_for_search. Update for new spec.
FWIW, the patch looks good to me. I think that this is an awesome
enhancement.
One thing I noticed is that we might want to apply the same treatement
to the "clear" command... It uses the filename_cmp function directly,
instead of using the FILENAME_CMP macro.
--
Joel
next prev parent reply other threads:[~2012-01-11 4:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 16:32 Tom Tromey
2012-01-10 17:40 ` Eli Zaretskii
2012-01-11 21:52 ` Tom Tromey
2012-01-12 6:23 ` Eli Zaretskii
2012-01-16 19:01 ` Tom Tromey
2012-12-08 16:34 ` Jan Kratochvil
2012-12-08 18:33 ` Eli Zaretskii
2013-01-07 15:17 ` [testcase patch] New testcase: DOS drive letters in linespec [Re: RFC: add relative file name handling for linespecs] Jan Kratochvil
2013-01-17 20:42 ` [commit] " Jan Kratochvil
2012-01-11 9:03 ` Joel Brobecker [this message]
2012-01-16 19:29 ` RFC: add relative file name handling for linespecs Tom Tromey
2012-01-16 21:07 ` Tom Tromey
2012-01-19 15:39 ` Performance regression (12x): " Jan Kratochvil
2012-01-19 16:35 ` Tom Tromey
2012-01-31 20:18 ` Tom Tromey
2012-02-01 10:22 ` Joel Brobecker
2012-02-01 15:04 ` Tom Tromey
2012-02-01 15:07 ` Tom Tromey
2012-02-01 15:18 ` Joel Brobecker
2012-02-01 15:35 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120111045330.GG31383@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).