From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9082 invoked by alias); 11 Jan 2012 04:54:14 -0000 Received: (qmail 9066 invoked by uid 22791); 11 Jan 2012 04:54:11 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Jan 2012 04:53:59 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 72E092BAFCA; Tue, 10 Jan 2012 23:53:58 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id FZ+ppE89NMm0; Tue, 10 Jan 2012 23:53:58 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 007712BAF21; Tue, 10 Jan 2012 23:53:57 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id A0662145615; Wed, 11 Jan 2012 08:53:30 +0400 (RET) Date: Wed, 11 Jan 2012 09:03:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: RFC: add relative file name handling for linespecs Message-ID: <20120111045330.GG31383@adacore.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00342.txt.bz2 > 2012-01-10 Tom Tromey > > * NEWS: Add item. > * symtab.h (compare_filenames_for_search): Declare. > * symtab.c (compare_filenames_for_search): New function. > (iterate_over_some_symtabs): Use it. > * symfile.h (struct quick_symbol_functions) > : Change spec. > * psymtab.c (partial_map_symtabs_matching_filename): Use > compare_filenames_for_search. Update for new spec. > * dwarf2read.c (dw2_map_symtabs_matching_filename): Use > compare_filenames_for_search. Update for new spec. FWIW, the patch looks good to me. I think that this is an awesome enhancement. One thing I noticed is that we might want to apply the same treatement to the "clear" command... It uses the filename_cmp function directly, instead of using the FILENAME_CMP macro. -- Joel