From: Joel Brobecker <brobecker@adacore.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] dwarf2read.c: Don't read pc/line-number mapping for type units
Date: Wed, 11 Jan 2012 09:06:00 -0000 [thread overview]
Message-ID: <20120111090446.GH31383@adacore.com> (raw)
In-Reply-To: <CADPb22S9zbiv=cHbwd_9QR_LzPNtZGXmNsMShcieofzWYqs8ww@mail.gmail.com>
> Appended is what I committed to trunk.
> I think it's fine.
[...]
> The memory space reduction is substantial so I'd like to get this in 7.4.
> [the reduction only kicks in for .debug_types, btw]
>
> 2012-01-10 Doug Evans <dje@google.com>
>
> * dwarf2read.c (dwarf_decode_lines): Remove arg "abfd". New arg
> "want_line_info". All callers updated.
> (dwarf_decode_lines_1): New function.
> (handle_DW_AT_stmt_list): Add function comment.
> New arg "want_line_info". All callers updated.
> (read_file_scope,read_type_unit_scope): Move comment from
> handle_DW_AT_stmt_list to here.
If the gain is substantial, and you think it's fine, then no objection
on my end.
--
Joel
next prev parent reply other threads:[~2012-01-11 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 1:46 Doug Evans
2012-01-10 3:51 ` Doug Evans
2012-01-10 3:55 ` Joel Brobecker
2012-01-10 21:46 ` Doug Evans
2012-01-11 9:06 ` Joel Brobecker [this message]
2012-01-11 19:24 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120111090446.GH31383@adacore.com \
--to=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).