From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21142 invoked by alias); 12 Jan 2012 22:26:27 -0000 Received: (qmail 21133 invoked by uid 22791); 12 Jan 2012 22:26:27 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Jan 2012 22:26:10 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0CMQ9Dk025242 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 12 Jan 2012 17:26:09 -0500 Received: from host2.jankratochvil.net (ovpn-116-21.ams2.redhat.com [10.36.116.21]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q0CMQ30P024680 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 12 Jan 2012 17:26:07 -0500 Date: Thu, 12 Jan 2012 22:27:00 -0000 From: Jan Kratochvil To: Paul Pluzhnikov Cc: Doug Evans , gdb-patches@sourceware.org Subject: Re: [patch] Fix for PR gdb/9538 (loading of separate debuginfo and symlinks). Message-ID: <20120112222602.GA12911@host2.jankratochvil.net> References: <20120112030648.14DBE190AFD@elbrus2.mtv.corp.google.com> <20120112212959.GA24491@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00438.txt.bz2 On Thu, 12 Jan 2012 23:19:17 +0100, Paul Pluzhnikov wrote: > On Thu, Jan 12, 2012 at 1:29 PM, Jan Kratochvil > wrote: > >> +  dir1 = xstrdup (objfile->name); > >> +  terminate_after_last_dir_separator (dir1); > >> +  canon_dir = lrealpath (dir1); > > > > lrealpath can return NULL.  GDB did not crash before.  It will now. > > Where? canon_dir is passed into the utility function, which checks for NULL > (as it did before). I misread some comment as a code before, sorry. I agree. > 2012-01-11 Paul Pluzhnikov > > PR gdb/9538 > * symfile.c (find_separate_debug_file): New function. > (terminate_after_last_dir_separator): Likewise. > (find_separate_debug_file_by_debuglink): Also try realpath. > > > testsuite/ChangeLog: > > PR gdb/9538 > * gdb.base/sepdebug.exp: New test. I do not see the new patch but the described changes look OK. Thanks, Jan