From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-87057-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9395 invoked by alias); 12 Jan 2012 23:55:15 -0000
Received: (qmail 9387 invoked by uid 22791); 12 Jan 2012 23:55:15 -0000
X-SWARE-Spam-Status: No, hits=-6.6 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Jan 2012 23:54:58 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0CNsv4o005175	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 12 Jan 2012 18:54:57 -0500
Received: from host2.jankratochvil.net (ovpn-116-21.ams2.redhat.com [10.36.116.21])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q0CNsptH002199	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Thu, 12 Jan 2012 18:54:55 -0500
Date: Fri, 13 Jan 2012 00:21:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Paul Pluzhnikov <ppluzhnikov@google.com>, gdb-patches@sourceware.org
Subject: [doc patch] gdbint: braces for two lines in code  [Re: [patch] Fix for PR gdb/9538 (loading of separate debuginfo and symlinks).]
Message-ID: <20120112235451.GA14124@host2.jankratochvil.net>
References: <20120112030648.14DBE190AFD@elbrus2.mtv.corp.google.com> <CADPb22TZqh1KJv0KXxRNuhV8PZH-Z31CcggzJMBDJYo3OuZKdA@mail.gmail.com> <CALoOobMVWJB=u6Y8OMyNeva1KcgU7FP8FpR2aFQ4b2e+=QUgOQ@mail.gmail.com> <20120112212959.GA24491@host2.jankratochvil.net> <CALoOobOBfT4n5zXp-=4qyS_7+c0hkhWwxop9B=5aAHuti+bAWg@mail.gmail.com> <CADPb22Q9qi3TsYw3ZFkAyuO6a0VEJ_wtM_4pe_tXzDW5myi29Q@mail.gmail.com> <20120112232521.GA25432@host2.jankratochvil.net> <CADPb22TJhVz=jwsQzEMC=9Jf+df4qXJJkzwN=PkX=fOK2=Lsfg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CADPb22TJhVz=jwsQzEMC=9Jf+df4qXJJkzwN=PkX=fOK2=Lsfg@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-01/txt/msg00454.txt.bz2

On Fri, 13 Jan 2012 00:28:35 +0100, Doug Evans wrote:
> I think we should make the braces required.

OK to check in?


Thanks,
Jan


gdb/doc/
2012-01-12  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* gdbint.texinfo (Coding Standards): Require braces for two lines of
	code.

--- a/gdb/doc/gdbint.texinfo
+++ b/gdb/doc/gdbint.texinfo
@@ -5849,6 +5849,26 @@ the following guidelines:
 @tab (pointer dereference)
 @end multitable
 
+Any two lines in code should be wrapped in braces as they look as separate
+statements:
+
+@smallexample
+if (i)
+  @{
+    /* Return success.  */
+    return 0;
+  @}
+@end smallexample
+
+@noindent
+and not:
+
+@smallexample
+if (i)
+  /* Return success.  */
+  return 0;
+@end smallexample
+
 @subsection Comments
 
 @cindex comment formatting