From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18133 invoked by alias); 13 Jan 2012 00:27:29 -0000 Received: (qmail 18124 invoked by uid 22791); 13 Jan 2012 00:27:28 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Jan 2012 00:27:05 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0D0R4jm017391 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 12 Jan 2012 19:27:04 -0500 Received: from host2.jankratochvil.net (ovpn-116-21.ams2.redhat.com [10.36.116.21]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q0D0R0ei015045 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 12 Jan 2012 19:27:03 -0500 Date: Fri, 13 Jan 2012 00:48:00 -0000 From: Jan Kratochvil To: Paul Pluzhnikov Cc: Doug Evans , gdb-patches@sourceware.org Subject: Re: [patch] Fix for PR gdb/9538 (loading of separate debuginfo and symlinks). Message-ID: <20120113002700.GA15378@host2.jankratochvil.net> References: <20120112030648.14DBE190AFD@elbrus2.mtv.corp.google.com> <20120112212959.GA24491@host2.jankratochvil.net> <20120112234239.GA6964@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00457.txt.bz2 On Fri, 13 Jan 2012 01:20:37 +0100, Paul Pluzhnikov wrote: > Could you commit it? Feel free to commit it along. The patch looks fine to me but maybe keep it here for a day or two. > Updated patch attached. (I also noticed incorrect use of make_cleanup; > now fixed.) It would be easy to remove the last "goto" there now when cleanups are in use. Thanks, Jan