From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Joel Brobecker <brobecker@adacore.com>,
palves@redhat.com, dje@google.com, ppluzhnikov@google.com,
gdb-patches@sourceware.org
Subject: [commit] [doc patch] gdbint: braces for two lines in code [Re: [patch] Fix for PR gdb/9538 (loading of separate debuginfo and symlinks).]
Date: Fri, 13 Jan 2012 14:37:00 -0000 [thread overview]
Message-ID: <20120113143232.GA14010@host2.jankratochvil.net> (raw)
In-Reply-To: <83pqenkc99.fsf@gnu.org>
On Fri, 13 Jan 2012 13:39:14 +0100, Eli Zaretskii wrote:
> > > Any two or more lines in code should be wrapped in braces, even if
> > > they are comments, as they look as separate statements:
> > ^^ like ?
>
> Fine with me, FWIW.
Checked in.
Thanks,
Jan
http://sourceware.org/ml/gdb-cvs/2012-01/msg00125.html
--- src/gdb/doc/ChangeLog 2012/01/11 10:34:21 1.1263
+++ src/gdb/doc/ChangeLog 2012/01/13 14:31:55 1.1264
@@ -1,3 +1,9 @@
+2012-01-13 Jan Kratochvil <jan.kratochvil@redhat.com>
+ Eli Zaretskii <eliz@gnu.org>
+
+ * gdbint.texinfo (Coding Standards): Require braces for two lines of
+ code.
+
2012-01-11 Paul Hilfinger <hilfingr@adacore.com>
* gdb.texinfo (Variables): Document use of :: for non-static
--- src/gdb/doc/gdbint.texinfo 2012/01/05 09:41:03 1.334
+++ src/gdb/doc/gdbint.texinfo 2012/01/13 14:31:55 1.335
@@ -5849,6 +5849,26 @@
@tab (pointer dereference)
@end multitable
+Any two or more lines in code should be wrapped in braces, even if
+they are comments, as they look like separate statements:
+
+@smallexample
+if (i)
+ @{
+ /* Return success. */
+ return 0;
+ @}
+@end smallexample
+
+@noindent
+and not:
+
+@smallexample
+if (i)
+ /* Return success. */
+ return 0;
+@end smallexample
+
@subsection Comments
@cindex comment formatting
next prev parent reply other threads:[~2012-01-13 14:33 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 3:12 [patch] Fix for PR gdb/9538 (loading of separate debuginfo and symlinks) Paul Pluzhnikov
2012-01-12 17:28 ` Doug Evans
2012-01-12 20:59 ` Paul Pluzhnikov
2012-01-12 21:31 ` Jan Kratochvil
2012-01-12 22:20 ` Paul Pluzhnikov
2012-01-12 22:27 ` Jan Kratochvil
2012-01-12 22:31 ` Paul Pluzhnikov
2012-01-12 22:29 ` Paul Pluzhnikov
2012-01-12 22:50 ` Jan Kratochvil
2012-01-12 23:12 ` Paul Pluzhnikov
2012-01-12 23:18 ` Jan Kratochvil
2012-01-12 23:25 ` Doug Evans
2012-01-12 23:27 ` Jan Kratochvil
2012-01-12 23:40 ` Doug Evans
2012-01-13 0:21 ` [doc patch] gdbint: braces for two lines in code [Re: [patch] Fix for PR gdb/9538 (loading of separate debuginfo and symlinks).] Jan Kratochvil
2012-01-13 0:27 ` Doug Evans
2012-01-13 4:02 ` Joel Brobecker
2012-01-13 11:09 ` Jan Kratochvil
2012-01-13 11:23 ` Pedro Alves
2012-01-13 11:55 ` Eli Zaretskii
2012-01-13 12:15 ` Joel Brobecker
2012-01-13 12:40 ` Eli Zaretskii
2012-01-13 14:37 ` Jan Kratochvil [this message]
2012-01-13 9:05 ` Eli Zaretskii
2012-01-12 23:28 ` [patch] Fix for PR gdb/9538 (loading of separate debuginfo and symlinks) Paul Pluzhnikov
2012-01-12 23:55 ` Jan Kratochvil
2012-01-13 0:21 ` Paul Pluzhnikov
2012-01-13 0:48 ` Jan Kratochvil
2012-01-13 3:39 ` Paul Pluzhnikov
2012-01-18 19:15 ` Paul Pluzhnikov
2012-01-12 22:26 ` Doug Evans
2012-01-12 22:40 ` Paul Pluzhnikov
2012-01-12 22:52 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120113143232.GA14010@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=brobecker@adacore.com \
--cc=dje@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).