From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24835 invoked by alias); 27 Jan 2012 19:01:59 -0000 Received: (qmail 24826 invoked by uid 22791); 27 Jan 2012 19:01:58 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Jan 2012 19:01:45 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A563A2BB10D; Fri, 27 Jan 2012 14:01:44 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id s1gmP6SjXb1N; Fri, 27 Jan 2012 14:01:44 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 35E682BB095; Fri, 27 Jan 2012 14:01:44 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 75B80145615; Fri, 27 Jan 2012 23:01:32 +0400 (RET) Date: Fri, 27 Jan 2012 19:27:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [patch] Fix the 2012-01-26 regression by la_get_symbol_name_match_p [Re: Crash regression gdb.cp/no-dmgl-verbose.exp] Message-ID: <20120127190132.GB31383@adacore.com> References: <20120126102148.GA24559@host2.jankratochvil.net> <20120126101635.GA24188@host2.jankratochvil.net> <20120127032004.GA3772@host2.jankratochvil.net> <20120127051509.GV31383@adacore.com> <20120127170035.GA9056@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120127170035.GA9056@host2.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00957.txt.bz2 > but it should be fixed. I will check in the patch below, it seems all the > functions return strcmp-like result. Duh! Thanks, Jan. The language hook is very poorly named, I apologize. Please go ahead and commit this fix immediately as is, and I will fix the language hook name (and its description!) this weekend. > gdb/ > 2012-01-27 Jan Kratochvil > > Fix the 2012-01-26 regression by la_get_symbol_name_match_p. > * linespec.c (iterate_name_matcher): Negate the SYMBOL_NAME_MATCH_P > result. > > --- a/gdb/linespec.c > +++ b/gdb/linespec.c > @@ -340,7 +340,7 @@ iterate_name_matcher (const char *name, void *d) > { > const struct symbol_matcher_data *data = d; > > - if (data->symbol_name_match_p (name, data->lookup_name)) > + if (data->symbol_name_match_p (name, data->lookup_name) == 0) > return 1; > return 0; > } Thanks again, -- Joel