From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26561 invoked by alias); 1 Feb 2012 10:22:09 -0000 Received: (qmail 26551 invoked by uid 22791); 1 Feb 2012 10:22:08 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Feb 2012 10:21:55 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 332062BB11F; Wed, 1 Feb 2012 05:21:55 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Z+CXz6-GdJG1; Wed, 1 Feb 2012 05:21:55 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B154E2BB098; Wed, 1 Feb 2012 05:21:54 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 13E38145615; Wed, 1 Feb 2012 14:21:38 +0400 (RET) Date: Wed, 01 Feb 2012 10:22:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: Performance regression (12x): Re: RFC: add relative file name handling for linespecs Message-ID: <20120201102137.GF31383@adacore.com> References: <20120119153236.GA6229@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00002.txt.bz2 Hi Tom, > Jan> I have noticed nightly regression testing to start randomly timing > Jan> out a lot for gdb.ada/* testcases, narrowed it down to this > Jan> check-in. > > I looked into this. I missed this message! You should have told me and I would have looked into it. > 2012-01-31 Tom Tromey > > * ada-lang.c (ada_lookup_symbol_list_full): New function, from > ada_lookup_symbol_list. Add 'full_search' argument. > (ada_lookup_symbol_list): Rewrite in terms of > ada_lookup_symbol_list_full. > (ada_iterate_over_symbols): Use ada_lookup_symbol_list_full. Thanks a lot for the patch. I agree that the patch looks correct, but I'm a little confused by the name of the new function (the _full suffix suggests that the lookup is always a full search). Traditionally, we've used a _1 suffix instead, which is very unimaginative and yet so convenient. I was going to change your patch this way, but in the end, I'm just thinking I should just add the parameter and update all callers. There are not that many. I suspect you might have thought about this too, only to just try the minimum change. Would it be OK with you if I made that change instead? -- Joel