From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20312 invoked by alias); 18 Apr 2012 14:43:22 -0000 Received: (qmail 20251 invoked by uid 22791); 18 Apr 2012 14:43:20 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Apr 2012 14:43:07 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id DBCAB1C6CCE; Wed, 18 Apr 2012 10:43:06 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Dqt2tzIp8Evx; Wed, 18 Apr 2012 10:43:06 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id AAA851C6902; Wed, 18 Apr 2012 10:43:06 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id D16E0145616; Wed, 18 Apr 2012 07:42:57 -0700 (PDT) Date: Wed, 18 Apr 2012 14:45:00 -0000 From: Joel Brobecker To: Paul Hilfinger Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Add proper handling for internal functions and STT_GNU_IFUNC symbols in Ada mode. Message-ID: <20120418144257.GB2852@adacore.com> References: <1334741131-29283-1-git-send-email-Hilfinger@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1334741131-29283-1-git-send-email-Hilfinger@adacore.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00578.txt.bz2 Hi Paul, > gdb/Changelog: > > * ada-lang.c (ada_evaluate_subexp): Add cases for > TYPE_CODE_INTERNAL_FUNCTION and for TYPE_GNU_IFUNC, following > their treatment in eval.c. This looks good to me. JIC: You're also Ada Maintainer, so you don't need approval for pure Ada changes.... Thanks! -- Joel