From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3868 invoked by alias); 6 Aug 2013 02:08:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3824 invoked by uid 89); 6 Aug 2013 02:08:49 -0000 X-Spam-SWARE-Status: No, score=-50.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_YE,RDNS_NONE autolearn=no version=3.3.1 Received: from Unknown (HELO mho-01-ewr.mailhop.org) (204.13.248.66) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 06 Aug 2013 02:08:48 +0000 Received: from pool-173-48-46-190.bstnma.fios.verizon.net ([173.48.46.190] helo=cgf.cx) by mho-01-ewr.mailhop.org with esmtpa (Exim 4.72) (envelope-from ) id 1V6WhV-000Md9-1J; Tue, 06 Aug 2013 02:08:41 +0000 Received: from localhost (ednor.casa.cgf.cx [192.168.187.5]) by cgf.cx (Postfix) with ESMTP id A166F60130; Mon, 5 Aug 2013 22:08:39 -0400 (EDT) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+sJl0+QzQEeoAJgBsVAYJ5 Date: Tue, 06 Aug 2013 02:08:00 -0000 From: Christopher Faylor To: gdb-patches@sourceware.org, Yao Qi Subject: Re: [PATCH 1/3] Detect GDB is in cygwin Message-ID: <20130806020839.GA3362@ednor.casa.cgf.cx> Mail-Followup-To: gdb-patches@sourceware.org, Yao Qi References: <1375087546-22591-1-git-send-email-yao@codesourcery.com> <1375087546-22591-2-git-send-email-yao@codesourcery.com> <83txjdxtpd.fsf@gnu.org> <51F786CB.3020700@codesourcery.com> <83a9l4xdst.fsf@gnu.org> <51FA137B.6070207@codesourcery.com> <20130803045452.GA997@ednor.casa.cgf.cx> <51FE1493.9070707@codesourcery.com> <20130805044122.GA1825@ednor.casa.cgf.cx> <51FF4483.5000102@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51FF4483.5000102@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-SW-Source: 2013-08/txt/msg00163.txt.bz2 On Mon, Aug 05, 2013 at 02:21:55PM +0800, Yao Qi wrote: >On 08/05/2013 12:41 PM, Christopher Faylor wrote: >>> I am not sure, but we never detect a cygwin pipe here. In >>> >using_cygwin_pty, we only check the file name of handle of stdin, to >>> >see its name match the template or not. We don't have to worry about >>> >it. >> Why can't the handle be a pipe? They also begin with "cygwin-". > >I don't understand your problem. Can you elaborate? or point out the >problem in the patch explicitly. I'm saying that it looks like your code will detect "echo yes | gdb" as running on a cygwin pty.