From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Use FILENAME_CMP to compare filenames in compare_search_syms.
Date: Wed, 02 Oct 2013 09:24:00 -0000 [thread overview]
Message-ID: <20131002092423.GA2971@adacore.com> (raw)
In-Reply-To: <524AE6E9.8030505@redhat.com>
> > Indeed! I'm turning this fix into a 2-patch series:
> >
> > 1. Delete search_symbols_equal
> >
> > This patch does not fix anything, other than removing the duplication.
> >
> > I pondered a bit over that change, thinking maybe we'd want
> > to keep it, just because the arguments have the right type
> > instead of "void *". In the end, I felt it was sufficiently
> > localized that deleting was OK. Putting it back is easy,
> > though, so whichever we want it shall be.
>
> This is fine with me.
>
> > * symtab.c (compare_search_syms): Use FILENAME_CMP instead of
> > strcmp to compare two symtab filenames.
>
> This one looks obvious to me.
Thanks, Pedro. Both patches are now in.
--
Joel
prev parent reply other threads:[~2013-10-02 9:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 9:07 Joel Brobecker
2013-10-01 9:54 ` Pedro Alves
2013-10-01 12:30 ` Joel Brobecker
2013-10-01 15:14 ` Pedro Alves
2013-10-02 9:24 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131002092423.GA2971@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).