From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18254 invoked by alias); 13 Oct 2013 16:39:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18242 invoked by uid 89); 13 Oct 2013 16:39:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 13 Oct 2013 16:39:33 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9DGdWaa030351 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 13 Oct 2013 12:39:32 -0400 Received: from host2.jankratochvil.net (ovpn-116-94.ams2.redhat.com [10.36.116.94]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r9DGdSSQ008272 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Sun, 13 Oct 2013 12:39:31 -0400 Date: Sun, 13 Oct 2013 16:39:00 -0000 From: Jan Kratochvil To: Ondrej Oprala Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH 04/18] poison "public" Message-ID: <20131013163928.GA12577@host2.jankratochvil.net> References: <1381339053-14519-1-git-send-email-ooprala@redhat.com> <1381339053-14519-5-git-send-email-ooprala@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1381339053-14519-5-git-send-email-ooprala@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00405.txt.bz2 On Wed, 09 Oct 2013 19:17:19 +0200, Ondrej Oprala wrote: > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -17,6 +17,10 @@ > > 2013-10-09 Tom Tromey > > + * gdbtypes.c (is_public): Renamed from public. It should use tab for indentation. But according to the "addrmap.c" text below your on-disk file is probably right but it just got corrupted by mail. Therefore mail it differently, please. You should put function name in parentheses. Therefore: * gdbtypes.c (distance_to_ancestor): Rename parameter public to is_public. But I disagree with "is_public", it does not have such meaning in this function. One could use for example "public_only", "require_public" or "traverse_public" here. Function-independent could be "public_flag". > + > +2013-10-09 Tom Tromey > + > * addrmap.c (self) : Renamed from this. > * cp-namespace.c (this_sym) : Likewise. > * frame.c (self) : Likewise. [...] Thanks, Jan