From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22077 invoked by alias); 13 Oct 2013 16:45:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22064 invoked by uid 89); 13 Oct 2013 16:45:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 13 Oct 2013 16:45:15 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9DGjEJP014662 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 13 Oct 2013 12:45:14 -0400 Received: from host2.jankratochvil.net (ovpn-116-94.ams2.redhat.com [10.36.116.94]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9DGjAJp023912 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Sun, 13 Oct 2013 12:45:13 -0400 Date: Sun, 13 Oct 2013 16:45:00 -0000 From: Jan Kratochvil To: Ondrej Oprala Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH 05/18] poison "private" Message-ID: <20131013164509.GA12719@host2.jankratochvil.net> References: <1381339053-14519-1-git-send-email-ooprala@redhat.com> <1381339053-14519-6-git-send-email-ooprala@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1381339053-14519-6-git-send-email-ooprala@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00406.txt.bz2 On Wed, 09 Oct 2013 19:17:20 +0200, Ondrej Oprala wrote: [...] > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -17,6 +17,17 @@ > > 2013-10-09 Tom Tromey > > + * gdbthread.h (private_data) : Renamed from private. Use tab + parentheses always contain only the global object name, in this case "struct thread_info". And s/ : /: /. Therefore: * gdbthread.h (struct thread_info): Rename field private to private_data. One could also use: * gdbthread.h (struct thread_info): Rename the field to private_data. > + * inferior.c (private_data) : Likewise. > + * inferior.h (private_data) : Likewise. > + * jit.c (private_unwind) : Likewise. > + * linux-thread-db.c (private_data, private_thr) : Likewise. > + * nto-tdep.c (private_data) : Likewise. > + * remote.c (private_data) : Likewise. > + * thread.c (private_dtor, private_data) : Likewise. Incorrect parentheses content like above. > + > +2013-10-09 Tom Tromey > + > * gdbtypes.c (is_public): Renamed from public. > > 2013-10-09 Tom Tromey [...] The patch itself is OK to commit. Thanks, Jan