public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: Keith Seitz <keiths@redhat.com>,
	       "gdb-patches@sourceware.org ml"
	<gdb-patches@sourceware.org>,
	       Sergio Durigan Junior <sergiodj@redhat.com>,
	       Tom Tromey <tromey@redhat.com>
Subject: Re: Regression for gdb.pascal/*  [Re: [RFA 4/4] Constify parse_linesepc]
Date: Fri, 18 Oct 2013 17:20:00 -0000	[thread overview]
Message-ID: <20131018172032.GA12122@host2.jankratochvil.net> (raw)
In-Reply-To: <87ob6ntyc4.fsf@fleche.redhat.com>

On Thu, 17 Oct 2013 22:51:55 +0200, Tom Tromey wrote:
> >>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
> 
> Keith> There are two little sections of code, though, which violate
> Keith> const-ness of the input, and I've removed those, since they don't
> Keith> seem necessary. [This is the two loops that deal with changing
> Keith> the case of `tokstart' -- which can easily be removed because we
> Keith> already have a temporary buffer that is used for this.]
> 
> I think it's somewhat wrong to do this stuff in the parser anyhow.
> Ideally the symbol table ought to know that pascal is case-insensitive.
> I think we faced this with Fortran as well.

Case insensitive symbols should be supported (originally written for Fortran)
since:
	commit 5b7743a275e4610fe6ea57f0c61e317490ee6854
	Date:   Wed Apr 27 20:03:03 2011 +0000
		Case insensitive lookups implementation.
(+about one fallout later)

While f_language_defn has case_sensitive_off
I see that pascal_language_defn has case_sensitive_on.

At https://en.wikipedia.org/wiki/Pascal_%28programming_language%29#Hello_world
I read
	Letter case is ignored in Pascal source.
so I think pascal_language_defn really should use case_sensitive_off.


Jan

  reply	other threads:[~2013-10-18 17:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-30 18:57 [RFA 4/4] Constify parse_linesepc Keith Seitz
2013-10-01  4:15 ` Sergio Durigan Junior
2013-10-01 20:16 ` Tom Tromey
2013-10-02  4:38   ` Keith Seitz
2013-10-16  9:57     ` Regression for gdb.pascal/* [Re: [RFA 4/4] Constify parse_linesepc] Jan Kratochvil
2013-10-16 22:07       ` Sergio Durigan Junior
2013-10-16 23:40         ` Sergio Durigan Junior
2013-10-17 18:18           ` Keith Seitz
2013-10-17 20:52             ` Tom Tromey
2013-10-18 17:20               ` Jan Kratochvil [this message]
2013-10-18 19:09                 ` [pascal patch] Use case_sensitive_off [Re: Regression for gdb.pascal/* [Re: [RFA 4/4] Constify parse_linesepc]] Jan Kratochvil
2013-10-18 19:34             ` Regression for gdb.pascal/* [Re: [RFA 4/4] Constify parse_linesepc] Jan Kratochvil
2013-10-20 13:17               ` Pierre Muller
2013-10-20 13:27                 ` Jan Kratochvil
2013-10-29 16:39               ` Tom Tromey
2013-10-31 16:14                 ` Pierre Muller
2013-11-13 20:43                   ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131018172032.GA12122@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    --cc=pierre.muller@ics-cnrs.unistra.fr \
    --cc=sergiodj@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).