From: Joel Brobecker <brobecker@adacore.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Remove varobj_language_string, languages and varobj_languages
Date: Sat, 26 Oct 2013 04:09:00 -0000 [thread overview]
Message-ID: <20131026040911.GD4769@adacore.com> (raw)
In-Reply-To: <526A7407.5090301@codesourcery.com>
> >I think this can do for now because it is good enough, but I would
> >definitely prefer we avoid this type transformation. Instead,
> >I'd rather we added a new field in struct language_defn that
> >provides the "natural" name.
> >
>
> I am OK to add a new field "la_varobj_name" in struct language_defn,
> but seems information is duplicated a little, we have both "c++" and
> "C++" in one language_defn.
It would not be a "varobj" name, but a "natural" name, that is the
name one would use when naming the language; eg: "Fortran 90" instead of
"f90". One possible analogy in our code base is the shortname/longname
distinction in struct target_ops.
--
Joel
next prev parent reply other threads:[~2013-10-26 4:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 0:54 [PATCH 1/2] New field la_varobj_ops in struct language_defn Yao Qi
2013-10-18 0:54 ` [PATCH 2/2] Remove varobj_language_string, languages and varobj_languages Yao Qi
2013-10-25 4:15 ` Joel Brobecker
2013-10-25 13:38 ` Yao Qi
2013-10-26 4:09 ` Joel Brobecker [this message]
2013-10-28 12:50 ` [PATCH 1/3] Constify 'la_name' in struct language_defn Yao Qi
2013-10-28 12:50 ` [PATCH 2/3] New field 'la_natural_name' " Yao Qi
2013-10-28 18:34 ` Tom Tromey
2013-10-29 8:41 ` Yao Qi
2013-11-07 7:18 ` Yao Qi
2013-10-28 12:50 ` [PATCH 3/3] Remove varobj_language_string, languages and varobj_languages Yao Qi
2013-10-28 18:52 ` Tom Tromey
2013-10-29 8:33 ` Yao Qi
2013-10-29 16:49 ` Eli Zaretskii
2013-10-31 3:10 ` Yao Qi
2013-10-31 17:31 ` Eli Zaretskii
2013-11-07 7:23 ` Yao Qi
2013-10-28 15:02 ` [PATCH 1/3] Constify 'la_name' in struct language_defn Tom Tromey
2013-10-25 3:34 ` [PATCH 1/2] New field la_varobj_ops " Joel Brobecker
2013-10-25 13:16 ` Yao Qi
2013-10-27 12:04 ` Rename field 'lang' to 'lang_ops' ([PATCH 1/2] New field la_varobj_ops in struct language_defn) Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131026040911.GD4769@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).