From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 710 invoked by alias); 14 Nov 2013 10:55:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 693 invoked by uid 89); 14 Nov 2013 10:55:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from Unknown (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 14 Nov 2013 10:55:47 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 95365116473; Thu, 14 Nov 2013 05:56:11 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id aor6JOj2IsSe; Thu, 14 Nov 2013 05:56:11 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2E86C116455; Thu, 14 Nov 2013 05:56:11 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id EF8B1E1804; Thu, 14 Nov 2013 14:55:36 +0400 (RET) Date: Thu, 14 Nov 2013 11:17:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [RFC 3/3] GDB/MI: Add new "--language LANG" command option. Message-ID: <20131114105536.GR3481@adacore.com> References: <1384151855-12926-1-git-send-email-brobecker@adacore.com> <1384151855-12926-3-git-send-email-brobecker@adacore.com> <5283D47A.4060900@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5283D47A.4060900@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-11/txt/msg00368.txt.bz2 > > This patch follows the same steps for the language, adding a similar > > new command option: --language LANG. Example of use: > > Makes sense to me. I skimmed the patch and it looked fine. > > > > > -data-evaluate-expression --language c "sizeof (void*)" > > ^done,value="4" > > > > gdb/ChangeLog: > > > > * mi/mi-parse.h (struct mi_parse) [language]: New field. > > [] is used for conditionally compiled code (#if FOO). For specifying > context, use <>. > > > * mi/mi-main.c (mi_cmd_execute): Temporarily set language to > > PARSE->LANGUAGE during command execution, if set. > > * mi/mi-parse.c: Add "language.h" #include. > > (mi_parse): Add parsing of "--language" command option. Thanks! I made the correction you pointed out, and pushed the commit. -- Joel