From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6308 invoked by alias); 2 Dec 2013 03:23:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6296 invoked by uid 89); 2 Dec 2013 03:23:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.2 required=5.0 tests=AWL,BAYES_05,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from Unknown (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 02 Dec 2013 03:23:45 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E88E81167DD; Sun, 1 Dec 2013 22:24:14 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 3POwNkNXSkyB; Sun, 1 Dec 2013 22:24:14 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 89BCE1167D8; Sun, 1 Dec 2013 22:24:14 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 55F4CE141B; Mon, 2 Dec 2013 07:23:33 +0400 (RET) Date: Mon, 02 Dec 2013 03:23:00 -0000 From: Joel Brobecker To: Chung-Lin Tang Cc: gdb-patches@sourceware.org, Sandra Loosemore Subject: Re: [patch, nios2] Update Linux parts for new syscall ABI Message-ID: <20131202032333.GN3114@adacore.com> References: <529AF143.9060704@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <529AF143.9060704@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-12/txt/msg00006.txt.bz2 > This patch updates the nios2-linux code for the new Linux generic system > call interface. Mainly removing (non-rt) sigreturn related definitions, > and updating the rt_sigreturn syscall NR. > > Will commit after Sandra's approval. I am sorry to be so procedural, but while Sandra input would probably be more valuable than most, Sandra is not yet listed as maintainer in GDB. She can therefore not approve patches for commit in the official repository yet. It should all be documented in gdb/MAINTAINERS. > 2013-12-01 Chung-Lin Tang > > gdb/ > * nios2-linux-tdep.c (nios2_linux_sigreturn_init): Remove. > (nios2_linux_sigreturn_tramp_frame): Remove. > (nios2_linux_rt_sigreturn_tramp_frame): Update rt_sigreturn syscall > number. > (nios2_linux_syscall_next_pc): Likewise. Remove sigreturn case. > (nios2_linux_init_abi): > Remove registration of nios2_linux_sigreturn_tramp_frame. My concern with your patch is that it seems to eliminate support for the previous syscall ABI, which means a break in compatibility. Unless we really have no other choice, I don't think we would want that. -- Joel