* [PATCH] PR gdb/16305: Mask out PREFIX_ADDR when adding prefix to opcode
@ 2013-12-08 20:14 H.J. Lu
2013-12-14 23:15 ` H.J. Lu
0 siblings, 1 reply; 2+ messages in thread
From: H.J. Lu @ 2013-12-08 20:14 UTC (permalink / raw)
To: GDB
PREFIX_ADDR isn't a prefix to opcode. This patch masks out PREFIX_ADDR
when adding prefix to opcode. Tested on Linux/x86-64. OK to install?
Thanks.
H.J.
---
2013-12-08 H.J. Lu <hongjiu.lu@intel.com>
PR gdb/16305
* i386-tdep.c (i386_process_record): Mask out PREFIX_ADDR when
adding prefix to opcode.
---
gdb/i386-tdep.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c
index 371d5f0..6635a25 100644
--- a/gdb/i386-tdep.c
+++ b/gdb/i386-tdep.c
@@ -7031,7 +7031,8 @@ no_support_3dnow_data:
case 0x0ffc:
case 0x0ffd:
case 0x0ffe:
- switch (prefixes)
+ /* Mask out PREFIX_ADDR. */
+ switch ((prefixes & ~PREFIX_ADDR))
{
case PREFIX_REPNZ:
opcode |= 0xf20000;
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] PR gdb/16305: Mask out PREFIX_ADDR when adding prefix to opcode
2013-12-08 20:14 [PATCH] PR gdb/16305: Mask out PREFIX_ADDR when adding prefix to opcode H.J. Lu
@ 2013-12-14 23:15 ` H.J. Lu
0 siblings, 0 replies; 2+ messages in thread
From: H.J. Lu @ 2013-12-14 23:15 UTC (permalink / raw)
To: Mark Kettenis; +Cc: GDB
On Sun, Dec 08, 2013 at 12:14:30PM -0800, H.J. Lu wrote:
> PREFIX_ADDR isn't a prefix to opcode. This patch masks out PREFIX_ADDR
> when adding prefix to opcode. Tested on Linux/x86-64. OK to install?
>
> Thanks.
>
> H.J.
> ---
> 2013-12-08 H.J. Lu <hongjiu.lu@intel.com>
>
> PR gdb/16305
> * i386-tdep.c (i386_process_record): Mask out PREFIX_ADDR when
> adding prefix to opcode.
> ---
> gdb/i386-tdep.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c
> index 371d5f0..6635a25 100644
> --- a/gdb/i386-tdep.c
> +++ b/gdb/i386-tdep.c
> @@ -7031,7 +7031,8 @@ no_support_3dnow_data:
> case 0x0ffc:
> case 0x0ffd:
> case 0x0ffe:
> - switch (prefixes)
> + /* Mask out PREFIX_ADDR. */
> + switch ((prefixes & ~PREFIX_ADDR))
> {
> case PREFIX_REPNZ:
> opcode |= 0xf20000;
> --
> 1.8.3.1
>
Hi Mark,
Do you get time to review this one-line change?
Thanks.
H.J.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-14 23:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-08 20:14 [PATCH] PR gdb/16305: Mask out PREFIX_ADDR when adding prefix to opcode H.J. Lu
2013-12-14 23:15 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).