From: Gary Benson <gbenson@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/4] change probes to be program-space-independent
Date: Tue, 17 Dec 2013 11:08:00 -0000 [thread overview]
Message-ID: <20131217110844.GA15900@blade.nx> (raw)
In-Reply-To: <1386100019-27379-4-git-send-email-tromey@redhat.com>
Tom Tromey wrote:
> This changes the probes to be independent of the program space.
>
> After this, when a probe's address is needed, it is determined by
> applying offsets at the point of use.
>
> This introduces a bound_probe object, similar to bound minimal
> symbols. Objects of this type are used when it's necessary to pass a
> probe and its corresponding objfile.
>
> This removes the backlink from probe to objfile, which was primarily
> used to fetch the architecture to use.
>
> This adds a get_probe_address function which calls a probe method to
> compute the probe's relocated address. Similarly, it adds an objfile
> parameter to the semaphore methods so they can do the relocation
> properly as well.
I haven't looked at the whole patch, but the solib-svr4.c bits look
good. Thanks for doing this work Tom.
Cheers,
Gary
--
http://gbenson.net/
next prev parent reply other threads:[~2013-12-17 11:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 19:47 [PATCH 0/4] make probes independent of the program space Tom Tromey
2013-12-03 19:47 ` [PATCH 2/4] remove some sym_probe_fns methods Tom Tromey
2013-12-05 23:06 ` Sergio Durigan Junior
2013-12-06 2:25 ` Sergio Durigan Junior
2013-12-06 15:54 ` Tom Tromey
2013-12-06 17:26 ` Tom Tromey
2013-12-06 18:23 ` Sergio Durigan Junior
2013-12-03 19:47 ` [PATCH 1/4] comment fixes Tom Tromey
2013-12-03 19:47 ` [PATCH 3/4] change probes to be program-space-independent Tom Tromey
2013-12-17 11:08 ` Gary Benson [this message]
2013-12-03 20:37 ` [PATCH 4/4] move probes to be per-bfd Tom Tromey
2013-12-05 17:10 ` [PATCH 0/4] make probes independent of the program space Pedro Alves
2013-12-05 19:10 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217110844.GA15900@blade.nx \
--to=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).