From: Joel Brobecker <brobecker@adacore.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Add target_xfer_partial_ftype
Date: Wed, 18 Dec 2013 02:36:00 -0000 [thread overview]
Message-ID: <20131218023650.GA3493@adacore.com> (raw)
In-Reply-To: <52B06BFD.7040809@redhat.com>
> > This patch adds a typedef target_xfer_partial_ftype. When we change
> > the signature of xfer_partial functions (for example, adding a new
> > parameter), we don't have to modify all of their declarations.
> >
> > This patch also updates the type of parameters of target_xfer_partial
> > from "void *" to "gdb_byte *".
> >
> > It is obvious to me, but comments are still welcome.
> >
>
> Thanks, looks good to me.
And FWIW, I really like it when we're using function types. These
types are also a good anchor for documenting their intended behavior.
--
Joel
next prev parent reply other threads:[~2013-12-18 2:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 13:17 Yao Qi
2013-12-17 15:21 ` Pedro Alves
2013-12-18 2:36 ` Joel Brobecker [this message]
2013-12-18 3:56 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131218023650.GA3493@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).